Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce log spam for large downloads made from mach #21905

Merged
merged 1 commit into from
Oct 11, 2018
Merged

Conversation

SimonSapin
Copy link
Member

@SimonSapin SimonSapin commented Oct 10, 2018

Printing the same line again is a no-op in an actual terminal, but Taskcluster’s log viewer shows each such line separately.


This change is Reviewable

Printing the same line again is a no-op on an actual terminal, but Taskcluster’s log viewer shows each such line separately.
@jdm
Copy link
Member

jdm commented Oct 10, 2018

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit e49fc39 has been approved by jdm

@highfive highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Oct 10, 2018
@bors-servo
Copy link
Contributor

⌛ Testing commit e49fc39 with merge e866e15...

bors-servo pushed a commit that referenced this pull request Oct 11, 2018
Reduce log spam for large downloads made from mach

Printing the same line again is a no-op in an actual terminal, but Taskcluster’s log viewer shows each such line separately.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21905)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - status-taskcluster

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Oct 11, 2018
@jdm
Copy link
Member

jdm commented Oct 11, 2018

@bors-servo retry

@bors-servo
Copy link
Contributor

⌛ Testing commit e49fc39 with merge 86909fa...

bors-servo pushed a commit that referenced this pull request Oct 11, 2018
Reduce log spam for large downloads made from mach

Printing the same line again is a no-op in an actual terminal, but Taskcluster’s log viewer shows each such line separately.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21905)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Oct 11, 2018
@bors-servo
Copy link
Contributor

💔 Test failed - android

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Oct 11, 2018
@jdm
Copy link
Member

jdm commented Oct 11, 2018

@bors-servo retry

@bors-servo
Copy link
Contributor

⌛ Testing commit e49fc39 with merge 25a91f7...

bors-servo pushed a commit that referenced this pull request Oct 11, 2018
Reduce log spam for large downloads made from mach

Printing the same line again is a no-op in an actual terminal, but Taskcluster’s log viewer shows each such line separately.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21905)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Oct 11, 2018
@bors-servo
Copy link
Contributor

💔 Test failed - mac-rel-css1

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Oct 11, 2018
bors-servo pushed a commit that referenced this pull request Oct 11, 2018
Reduce log spam for large downloads made from mach

Printing the same line again is a no-op in an actual terminal, but Taskcluster’s log viewer shows each such line separately.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21905)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

⌛ Testing commit e49fc39 with merge 222a89a...

@highfive highfive removed the S-tests-failed The changes caused existing tests to fail. label Oct 11, 2018
@highfive highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Oct 11, 2018
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel-css

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Oct 11, 2018
@ferjm
Copy link
Contributor

ferjm commented Oct 11, 2018

@bors-servo
Copy link
Contributor

⌛ Testing commit e49fc39 with merge ef42ab1...

bors-servo pushed a commit that referenced this pull request Oct 11, 2018
Reduce log spam for large downloads made from mach

Printing the same line again is a no-op in an actual terminal, but Taskcluster’s log viewer shows each such line separately.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21905)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Oct 11, 2018
@bors-servo
Copy link
Contributor

💔 Test failed - status-taskcluster

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Oct 11, 2018
@ferjm
Copy link
Contributor

ferjm commented Oct 11, 2018

@bors-servo retry

@bors-servo
Copy link
Contributor

⌛ Testing commit e49fc39 with merge 597f7c1...

bors-servo pushed a commit that referenced this pull request Oct 11, 2018
Reduce log spam for large downloads made from mach

Printing the same line again is a no-op in an actual terminal, but Taskcluster’s log viewer shows each such line separately.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21905)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Oct 11, 2018
@bors-servo
Copy link
Contributor

@bors-servo bors-servo merged commit e49fc39 into master Oct 11, 2018
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Oct 11, 2018
@SimonSapin SimonSapin deleted the log-spam branch October 11, 2018 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants