Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce log spam for large downloads made from mach #21905

Merged
merged 1 commit into from Oct 11, 2018
Merged

Reduce log spam for large downloads made from mach #21905

merged 1 commit into from Oct 11, 2018

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Oct 10, 2018

Printing the same line again is a no-op in an actual terminal, but Taskcluster’s log viewer shows each such line separately.


This change is Reviewable

Printing the same line again is a no-op on an actual terminal, but Taskcluster’s log viewer shows each such line separately.
@jdm
Copy link
Member

jdm commented Oct 10, 2018

@bors-servo
Copy link
Contributor

bors-servo commented Oct 10, 2018

📌 Commit e49fc39 has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented Oct 11, 2018

Testing commit e49fc39 with merge e866e15...

bors-servo added a commit that referenced this pull request Oct 11, 2018
Reduce log spam for large downloads made from mach

Printing the same line again is a no-op in an actual terminal, but Taskcluster’s log viewer shows each such line separately.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21905)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 11, 2018

💔 Test failed - status-taskcluster

@jdm
Copy link
Member

jdm commented Oct 11, 2018

@bors-servo retry

@bors-servo
Copy link
Contributor

bors-servo commented Oct 11, 2018

Testing commit e49fc39 with merge 86909fa...

bors-servo added a commit that referenced this pull request Oct 11, 2018
Reduce log spam for large downloads made from mach

Printing the same line again is a no-op in an actual terminal, but Taskcluster’s log viewer shows each such line separately.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21905)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 11, 2018

💔 Test failed - android

@jdm
Copy link
Member

jdm commented Oct 11, 2018

@bors-servo retry

@bors-servo
Copy link
Contributor

bors-servo commented Oct 11, 2018

Testing commit e49fc39 with merge 25a91f7...

bors-servo added a commit that referenced this pull request Oct 11, 2018
Reduce log spam for large downloads made from mach

Printing the same line again is a no-op in an actual terminal, but Taskcluster’s log viewer shows each such line separately.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21905)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 11, 2018

💔 Test failed - mac-rel-css1

@ferjm
Copy link
Member

ferjm commented Oct 11, 2018

bors-servo added a commit that referenced this pull request Oct 11, 2018
Reduce log spam for large downloads made from mach

Printing the same line again is a no-op in an actual terminal, but Taskcluster’s log viewer shows each such line separately.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21905)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 11, 2018

Testing commit e49fc39 with merge 222a89a...

@bors-servo
Copy link
Contributor

bors-servo commented Oct 11, 2018

💔 Test failed - linux-rel-css

@ferjm
Copy link
Member

ferjm commented Oct 11, 2018

@bors-servo
Copy link
Contributor

bors-servo commented Oct 11, 2018

Testing commit e49fc39 with merge ef42ab1...

bors-servo added a commit that referenced this pull request Oct 11, 2018
Reduce log spam for large downloads made from mach

Printing the same line again is a no-op in an actual terminal, but Taskcluster’s log viewer shows each such line separately.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21905)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 11, 2018

💔 Test failed - status-taskcluster

@ferjm
Copy link
Member

ferjm commented Oct 11, 2018

@bors-servo retry

@bors-servo
Copy link
Contributor

bors-servo commented Oct 11, 2018

Testing commit e49fc39 with merge 597f7c1...

bors-servo added a commit that referenced this pull request Oct 11, 2018
Reduce log spam for large downloads made from mach

Printing the same line again is a no-op in an actual terminal, but Taskcluster’s log viewer shows each such line separately.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21905)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 11, 2018

@bors-servo bors-servo merged commit e49fc39 into master Oct 11, 2018
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@SimonSapin SimonSapin deleted the log-spam branch Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.