Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow reusing AudioBuffers #21910

Merged
merged 6 commits into from Oct 11, 2018
Merged

Allow reusing AudioBuffers #21910

merged 6 commits into from Oct 11, 2018

Conversation

@ferjm
Copy link
Member

ferjm commented Oct 11, 2018 •
edited by SimonSapin

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #21887
  • There are tests for these changes

This change is Reviewable
@highfive
Copy link

highfive commented Oct 11, 2018

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/audiobuffer.rs, components/script/dom/audiobuffersourcenode.rs
  • @KiChjang: components/script/dom/audiobuffer.rs, components/script/dom/audiobuffersourcenode.rs
@highfive
Copy link

highfive commented Oct 11, 2018

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
@ferjm ferjm changed the title Audiobuffer.shared.fix Allow reusing AudioBuffers Oct 11, 2018
@ferjm
Copy link
Member Author

ferjm commented Oct 11, 2018

@bors-servo try=wpt
bors-servo added a commit that referenced this pull request Oct 11, 2018
@bors-servo
Auto merge of #21910 - ferjm:audiobuffer.shared.fix, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a86b21b 
Allow reusing AudioBuffers

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #21887
- [X] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21910)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 11, 2018

⌛ Trying commit ed1239b with merge a86b21b...
@bors-servo
Copy link
Contributor

bors-servo commented Oct 11, 2018

💔 Test failed - linux-rel-wpt
@Manishearth
Update servo-media
Loading status checks…
3c6e994
@ferjm
Copy link
Member Author

ferjm commented Oct 11, 2018

I am not sure why the tests were marked as PASS before, but all the errors seem to be caused because we don't support start()'s offset and duration params yet
@ferjm ferjm force-pushed the ferjm:audiobuffer.shared.fix branch from ed1239b to 77976ae Oct 11, 2018
@ferjm
Copy link
Member Author

ferjm commented Oct 11, 2018

r? @Manishearth

(This might need a rebase after #21915 is merged)
@highfive highfive assigned Manishearth and unassigned paulrouget Oct 11, 2018
ferjm added 3 commits Oct 11, 2018
@ferjm
Allow reusing AudioBuffers
091ad49
@ferjm
Add test to check that AudioBuffers can be reused between AudioBuffer…
52d898d 
…SourceNodes
@ferjm
Regenerate WebAudio WPTs expectations
Loading status checks…
afb824e
@ferjm ferjm force-pushed the ferjm:audiobuffer.shared.fix branch from 77976ae to afb824e Oct 11, 2018
@servo-wpt-sync servo-wpt-sync mentioned this pull request Oct 11, 2018
Merged
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Oct 11, 2018

Opened new PR for upstreamable changes.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#13475.
@Manishearth
Copy link
Member

Manishearth commented Oct 11, 2018

@bors-servo r+ p=1
@bors-servo
Copy link
Contributor

bors-servo commented Oct 11, 2018

📌 Commit afb824e has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Oct 11, 2018

⌛ Testing commit afb824e with merge 3af89f0...
bors-servo added a commit that referenced this pull request Oct 11, 2018
@bors-servo
Auto merge of #21910 - ferjm:audiobuffer.shared.fix, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3af89f0 
Allow reusing AudioBuffers

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #21887
- [X] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21910)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 11, 2018

💔 Test failed - linux-rel-css
@Manishearth
Copy link
Member

Manishearth commented Oct 11, 2018

@bors-servo retry
@Manishearth Manishearth mentioned this pull request Oct 11, 2018
Closed
@bors-servo
Copy link
Contributor

bors-servo commented Oct 11, 2018

⚡ Previous build results for android, android-x86, arm32, arm64, linux-dev, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt2, mac-rel-wpt4, status-taskcluster, windows-msvc-dev are reusable. Rebuilding only linux-rel-css, linux-rel-wpt, mac-rel-wpt1, mac-rel-wpt3...
@bors-servo
Copy link
Contributor

bors-servo commented Oct 11, 2018

💔 Test failed - mac-rel-wpt1
@Manishearth
Copy link
Member

Manishearth commented Oct 11, 2018

I know how to fix that intermittent
@Manishearth
Copy link
Member

Manishearth commented Oct 11, 2018

@bors-servo retry
Manishearth added 2 commits Oct 11, 2018
@Manishearth
More accurate names for .started and .stopped
40641ac
@Manishearth
Update servo-media to include DestinationNode fix
Loading status checks…
b7e9aeb
@Manishearth
Copy link
Member

Manishearth commented Oct 11, 2018

@bors-servo r+

rolled in the AudioDestinationNode fix
@bors-servo
Copy link
Contributor

bors-servo commented Oct 11, 2018

📌 Commit b7e9aeb has been approved by Manishearth
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Oct 11, 2018

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#13475.
@Manishearth Manishearth mentioned this pull request Oct 11, 2018
Closed
@bors-servo
Copy link
Contributor

bors-servo commented Oct 11, 2018

⌛ Testing commit b7e9aeb with merge bf192ca...
bors-servo added a commit that referenced this pull request Oct 11, 2018
@bors-servo
Auto merge of #21910 - ferjm:audiobuffer.shared.fix, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
bf192ca 
Allow reusing AudioBuffers

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #21887
- [X] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21910)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 11, 2018

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, status-taskcluster, windows-msvc-dev
Approved by: Manishearth
Pushing bf192ca to master...
@bors-servo bors-servo merged commit b7e9aeb into servo:master Oct 11, 2018
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@ferjm ferjm deleted the ferjm:audiobuffer.shared.fix branch Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

AudioBuffer can't be reused between BufferSourceNodes
6 participants
@ferjm @highfive @bors-servo @servo-wpt-sync @Manishearth @paulrouget
You can’t perform that action at this time.