Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean some temporary files from Windows packaging process #21913

Merged
merged 1 commit into from Oct 16, 2018
Merged

Clean some temporary files from Windows packaging process #21913

merged 1 commit into from Oct 16, 2018

Conversation

@ferjm
Copy link
Member

ferjm commented Oct 11, 2018 •
edited by SimonSapin

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors

This change is Reviewable
@highfive
Copy link

highfive commented Oct 11, 2018

Heads up! This PR modifies the following files:
@ferjm
Copy link
Member Author

ferjm commented Oct 11, 2018

@bors-servo try=windows
@bors-servo
Copy link
Contributor

bors-servo commented Oct 11, 2018

⌛ Trying commit 4bf434f with merge 2537f74...
bors-servo added a commit that referenced this pull request Oct 11, 2018
@bors-servo
Auto merge of #21913 - ferjm:rm.windows.nightly.zip, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
2537f74 
Do not generate and upload zip with Windows nightly contents

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21913)
<!-- Reviewable:end -->
@ferjm
Copy link
Member Author

ferjm commented Oct 11, 2018

r? @jdm
@highfive highfive assigned jdm and unassigned avadacatavra Oct 11, 2018
@jdm
Copy link
Member

jdm commented Oct 11, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Oct 11, 2018

📌 Commit 4bf434f has been approved by jdm
@SimonSapin
Copy link
Member

SimonSapin commented Oct 11, 2018

Why this change?

My recent experience with adding Windows builds on Taskcluster is that executable installers can be a pain to deal with, so also providing "dumb" archives can be helpful.
@jdm
Copy link
Member

jdm commented Oct 11, 2018

The concern is that the installer works out of the box, but the zip file only works if you have installed gstreamer separately. Since we're not trying to do any particular distribution strategy right now, I would prefer to highlight builds which do not require any further troubleshooting to work correctly.
@SimonSapin
Copy link
Member

SimonSapin commented Oct 11, 2018

Could we keep uploading ZIP files, but not advertise them of the website?
@ferjm
Copy link
Member Author

ferjm commented Oct 11, 2018

Sure. I guess it's fine to continue uploading the zip as long as someone finds it useful.

servo/download.servo.org#45 removes the link from the website.

@bors-servo r-
@atouchet
Copy link
Contributor

atouchet commented Oct 11, 2018

Could we keep uploading ZIP files, but not advertise them of the website?

I would also like this. I find the ZIP versions much more convenient to use for testing compared to the installer.
@jdm
Copy link
Member

jdm commented Oct 11, 2018

@bors-servo r-
@ferjm
Clean some temporary files from Windows packaging process
Loading status checks…
589b278
@ferjm ferjm force-pushed the ferjm:rm.windows.nightly.zip branch from 4bf434f to 589b278 Oct 16, 2018
@ferjm ferjm changed the title Do not generate and upload zip with Windows nightly contents Clean some temporary files from Windows packaging process Oct 16, 2018
@ferjm
Copy link
Member Author

ferjm commented Oct 16, 2018

I'm landing the second commit only, which is still a valid cleanup.

@bors-servo r=jdm
@bors-servo
Copy link
Contributor

bors-servo commented Oct 16, 2018

📌 Commit 589b278 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Oct 16, 2018

⌛ Testing commit 589b278 with merge 9ea4ca4...
bors-servo added a commit that referenced this pull request Oct 16, 2018
@bors-servo
Auto merge of #21913 - ferjm:rm.windows.nightly.zip, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9ea4ca4 
Clean some temporary files from Windows packaging process

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21913)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 16, 2018

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, status-taskcluster, windows-msvc-dev
Approved by: jdm
Pushing 9ea4ca4 to master...
@bors-servo bors-servo merged commit 589b278 into servo:master Oct 16, 2018
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@ferjm ferjm deleted the ferjm:rm.windows.nightly.zip branch Oct 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@ferjm @highfive @bors-servo @jdm @SimonSapin @atouchet @avadacatavra
You can’t perform that action at this time.