Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement ParentNode.children for Document and Element #2192
Conversation
highfive
commented
Apr 19, 2014
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @metajack (or someone else) soon. |
hoppipolla-critic-bot
commented
Apr 19, 2014
|
Critic review: https://critic.hoppipolla.co.uk/r/1329 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
Also implement it for DocumentFragment
This comment has been minimized.
This comment has been minimized.
Ms2ger
commented on 4c057de
Apr 22, 2014
|
r+ |
This comment has been minimized.
This comment has been minimized.
|
saw approval from Ms2ger |
This comment has been minimized.
This comment has been minimized.
|
merging evilpie/servo/children = 4c057de into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
all tests pass: |
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = b35d830 |
4c057de
into
servo:master
evilpie commentedApr 19, 2014
Fixes #2186