Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ParentNode.children for Document and Element #2192

Merged
merged 1 commit into from Apr 22, 2014

Conversation

@evilpie
Copy link
Contributor

evilpie commented Apr 19, 2014

Fixes #2186

@highfive
Copy link

highfive commented Apr 19, 2014

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @metajack (or someone else) soon.

@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Apr 19, 2014

Critic review: https://critic.hoppipolla.co.uk/r/1329

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

Also implement it for DocumentFragment
@Ms2ger

This comment has been minimized.

Copy link

Ms2ger commented on 4c057de Apr 22, 2014

r+

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on 4c057de Apr 22, 2014

saw approval from Ms2ger
at evilpie@4c057de

This comment has been minimized.

Copy link
Contributor

bors-servo replied Apr 22, 2014

merging evilpie/servo/children = 4c057de into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Apr 22, 2014

evilpie/servo/children = 4c057de merged ok, testing candidate = b35d830

This comment has been minimized.

Copy link
Contributor

bors-servo replied Apr 22, 2014

fast-forwarding master to auto = b35d830

bors-servo pushed a commit that referenced this pull request Apr 22, 2014
@bors-servo bors-servo merged commit 4c057de into servo:master Apr 22, 2014
1 check passed
1 check passed
default all tests passed
@evilpie evilpie deleted the evilpie:children branch Nov 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can’t perform that action at this time.