New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a depth buffer when embedding Servo on android. #21921

Merged
merged 1 commit into from Oct 12, 2018

Conversation

Projects
None yet
5 participants
@jdm
Member

jdm commented Oct 11, 2018

Webrender uses the z-buffer but does not check that it's present. We need to provide one for pages to render correctly.


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #21807
  • These changes do not require tests because there are no automated tests for embedding Servo in Firefox Reality.

This change is Reviewable

@gw3583

This comment has been minimized.

Contributor

gw3583 commented Oct 11, 2018

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 11, 2018

📌 Commit 03a75f4 has been approved by gw3583

@jdm

This comment has been minimized.

Member

jdm commented Oct 11, 2018

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 11, 2018

⌛️ Testing commit 03a75f4 with merge b6a1a58...

bors-servo added a commit that referenced this pull request Oct 11, 2018

Auto merge of #21921 - servo:jdm-patch-6-1, r=gw3583
Use a depth buffer when embedding Servo on android.

Webrender uses the z-buffer but does not check that it's present. We need to provide one for pages to render correctly.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #21807
- [x] These changes do not require tests because there are no automated tests for embedding Servo in Firefox Reality.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21921)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 11, 2018

💔 Test failed - status-taskcluster

@jdm

This comment has been minimized.

Member

jdm commented Oct 12, 2018

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 12, 2018

⌛️ Testing commit 03a75f4 with merge 6551fc5...

bors-servo added a commit that referenced this pull request Oct 12, 2018

Auto merge of #21921 - servo:jdm-patch-6-1, r=gw3583
Use a depth buffer when embedding Servo on android.

Webrender uses the z-buffer but does not check that it's present. We need to provide one for pages to render correctly.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #21807
- [x] These changes do not require tests because there are no automated tests for embedding Servo in Firefox Reality.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21921)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 12, 2018

💔 Test failed - status-taskcluster

@jdm

This comment has been minimized.

Member

jdm commented Oct 12, 2018

@bors-servo retry

  • network issues
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 12, 2018

⌛️ Testing commit 03a75f4 with merge 2d8cef3...

bors-servo added a commit that referenced this pull request Oct 12, 2018

Auto merge of #21921 - servo:jdm-patch-6-1, r=gw3583
Use a depth buffer when embedding Servo on android.

Webrender uses the z-buffer but does not check that it's present. We need to provide one for pages to render correctly.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #21807
- [x] These changes do not require tests because there are no automated tests for embedding Servo in Firefox Reality.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21921)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 12, 2018

💔 Test failed - linux-rel-wpt

@jdm

This comment has been minimized.

Member

jdm commented Oct 12, 2018

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 12, 2018

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 12, 2018

@bors-servo bors-servo merged commit 03a75f4 into master Oct 12, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@emilio emilio deleted the jdm-patch-6-1 branch Oct 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment