Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a depth buffer when embedding Servo on android. #21921

Merged
merged 1 commit into from Oct 12, 2018
Merged

Use a depth buffer when embedding Servo on android. #21921

merged 1 commit into from Oct 12, 2018

Conversation

@jdm
Copy link
Member

jdm commented Oct 11, 2018 •
edited by SimonSapin

Webrender uses the z-buffer but does not check that it's present. We need to provide one for pages to render correctly.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #21807
  • These changes do not require tests because there are no automated tests for embedding Servo in Firefox Reality.

This change is Reviewable
@jdm
Use a depth buffer when embedding Servo on android.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
03a75f4
@gw3583
Copy link
Contributor

gw3583 commented Oct 11, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Oct 11, 2018

📌 Commit 03a75f4 has been approved by gw3583
@highfive highfive assigned gw3583 and unassigned avadacatavra Oct 11, 2018
@jdm
Copy link
Member Author

jdm commented Oct 11, 2018

@bors-servo p=1
@bors-servo
Copy link
Contributor

bors-servo commented Oct 11, 2018

⌛ Testing commit 03a75f4 with merge b6a1a58...
bors-servo added a commit that referenced this pull request Oct 11, 2018
@bors-servo
Auto merge of #21921 - servo:jdm-patch-6-1, r=gw3583
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b6a1a58 
Use a depth buffer when embedding Servo on android.

Webrender uses the z-buffer but does not check that it's present. We need to provide one for pages to render correctly.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #21807
- [x] These changes do not require tests because there are no automated tests for embedding Servo in Firefox Reality.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21921)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 11, 2018

💔 Test failed - status-taskcluster
@jdm
Copy link
Member Author

jdm commented Oct 12, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Oct 12, 2018

⌛ Testing commit 03a75f4 with merge 6551fc5...
bors-servo added a commit that referenced this pull request Oct 12, 2018
@bors-servo
Auto merge of #21921 - servo:jdm-patch-6-1, r=gw3583
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6551fc5 
Use a depth buffer when embedding Servo on android.

Webrender uses the z-buffer but does not check that it's present. We need to provide one for pages to render correctly.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #21807
- [x] These changes do not require tests because there are no automated tests for embedding Servo in Firefox Reality.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21921)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 12, 2018

💔 Test failed - status-taskcluster
@jdm
Copy link
Member Author

jdm commented Oct 12, 2018

@bors-servo retry

  • network issues
@bors-servo
Copy link
Contributor

bors-servo commented Oct 12, 2018

⌛ Testing commit 03a75f4 with merge 2d8cef3...
bors-servo added a commit that referenced this pull request Oct 12, 2018
@bors-servo
Auto merge of #21921 - servo:jdm-patch-6-1, r=gw3583
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
2d8cef3 
Use a depth buffer when embedding Servo on android.

Webrender uses the z-buffer but does not check that it's present. We need to provide one for pages to render correctly.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #21807
- [x] These changes do not require tests because there are no automated tests for embedding Servo in Firefox Reality.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21921)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 12, 2018

💔 Test failed - linux-rel-wpt
@jdm
Copy link
Member Author

jdm commented Oct 12, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Oct 12, 2018

⚡ Previous build results for android, android-x86, arm32, arm64, linux-dev, linux-rel-css, mac-dev-unit, mac-rel-css1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, status-taskcluster, windows-msvc-dev are reusable. Rebuilding only linux-rel-wpt, mac-rel-css2, mac-rel-wpt1...
@bors-servo
Copy link
Contributor

bors-servo commented Oct 12, 2018

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, status-taskcluster, windows-msvc-dev
Approved by: gw3583
Pushing 2d8cef3 to master...
@bors-servo bors-servo merged commit 03a75f4 into master Oct 12, 2018
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@emilio emilio deleted the jdm-patch-6-1 branch Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gw3583 gw3583

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

ServoSurface: black screen with webGL demos
5 participants
@jdm @gw3583 @bors-servo @highfive @avadacatavra
You can’t perform that action at this time.