Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for StorageEvent.initstorageevent() #21922

Merged
merged 1 commit into from Oct 12, 2018
Merged

Add support for StorageEvent.initstorageevent() #21922

merged 1 commit into from Oct 12, 2018

Conversation

@Eijebong
Copy link
Member

Eijebong commented Oct 11, 2018 •
edited by SimonSapin

Fixes #21874

This change is Reviewable
@Eijebong
Add support for StorageEvent.initstorageevent()
Loading status checks…
5347e25 
Fixes #21874
@highfive
Copy link

highfive commented Oct 11, 2018

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/webidls/StorageEvent.webidl, components/script/dom/storageevent.rs
  • @KiChjang: components/script/dom/webidls/StorageEvent.webidl, components/script/dom/storageevent.rs
@SimonSapin
Copy link
Member

SimonSapin commented Oct 12, 2018

I know ~nothing about this API, but the code looks reasonable and appears to match the spec.

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Oct 12, 2018

📌 Commit 5347e25 has been approved by SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Oct 12, 2018

⌛ Testing commit 5347e25 with merge fa94fc7...
bors-servo added a commit that referenced this pull request Oct 12, 2018
@bors-servo
Auto merge of #21922 - Eijebong:storage, r=SimonSapin
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
fa94fc7 
Add support for StorageEvent.initstorageevent()

Fixes #21874

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21922)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 12, 2018

💔 Test failed - mac-rel-css1
@jdm
Copy link
Member

jdm commented Oct 12, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Oct 12, 2018

⚡ Previous build results for android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, status-taskcluster, windows-msvc-dev are reusable. Rebuilding only mac-rel-css1...
@bors-servo
Copy link
Contributor

bors-servo commented Oct 12, 2018

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, status-taskcluster, windows-msvc-dev
Approved by: SimonSapin
Pushing fa94fc7 to master...
@bors-servo bors-servo merged commit 5347e25 into servo:master Oct 12, 2018
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SimonSapin SimonSapin

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@Eijebong @highfive @SimonSapin @bors-servo @jdm
You can’t perform that action at this time.