Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up🐈🐈🐈 Implement basic <source> take-first-then-fail algo for HtmlMediaElement #21923
+22
−3
Conversation
highfive
commented
Oct 11, 2018
|
Heads up! This PR modifies the following files:
|
highfive
commented
Oct 11, 2018
|
|
est31
changed the title
The spec has a complicated algorithm for selecting a <source> element among multiple <source> children of a HtmlMediaElement where it loops over all of them, tries each and takes the first where "everything works out". This commit implements a much simpler and restricted approach by just taking the first <source> child, and if that fails, failing altogether, without looking at any further children. This is an improvement over the current status and makes gifv items on imgur playable, although it doesn't mean full <source> support.
|
@bors-servo try=wpt |
bors-servo
added a commit
that referenced
this pull request
Oct 15, 2018
🐈 🐈 🐈 Implement basic <source> take-first-then-fail algo for HtmlMediaElement The spec has a complicated algorithm for selecting a <source> element among multiple <source> children of a HtmlMediaElement where it loops over all of them, tries each and takes the first where "everything works out". This PR implements a much simpler and restricted approach by just taking the first <source> child, and if that fails, failing altogether, without looking at any further children. This is an improvement over the current status and makes gifv items on imgur playable, although it doesn't mean full <source> support. See it in action: https://i.imgur.com/WoEhYj3.gifv <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [X] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21923) <!-- Reviewable:end -->
|
|
|
There were no unexpected test results. |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 16, 2018
🐈 🐈 🐈 Implement basic <source> take-first-then-fail algo for HtmlMediaElement The spec has a complicated algorithm for selecting a <source> element among multiple <source> children of a HtmlMediaElement where it loops over all of them, tries each and takes the first where "everything works out". This PR implements a much simpler and restricted approach by just taking the first <source> child, and if that fails, failing altogether, without looking at any further children. This is an improvement over the current status and makes gifv items on imgur playable, although it doesn't mean full <source> support. See it in action: https://i.imgur.com/WoEhYj3.gifv <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [X] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21923) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
est31 commentedOct 11, 2018
•
edited by SimonSapin
The spec has a complicated algorithm for selecting a
element among multiple children of a HtmlMediaElement
where it loops over all of them, tries each and takes the first
where "everything works out".
This PR implements a much simpler and restricted approach by
just taking the first child, and if that fails,
failing altogether, without looking at any further children.
This is an improvement over the current status and makes gifv
items on imgur playable, although it doesn't mean full
support.
See it in action: https://i.imgur.com/WoEhYj3.gifv
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is