Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐈🐈🐈 Implement basic <source> take-first-then-fail algo for HtmlMediaElement #21923

Merged
merged 1 commit into from Oct 16, 2018

Commits on Oct 12, 2018

  1. Implement basic <source> support for HtmlMediaElement

    The spec has a complicated algorithm for selecting a <source>
    element among multiple <source> children of a HtmlMediaElement
    where it loops over all of them, tries each and takes the first
    where "everything works out".
    
    This commit implements a much simpler and restricted approach by
    just taking the first <source> child, and if that fails,
    failing altogether, without looking at any further children.
    
    This is an improvement over the current status and makes gifv
    items on imgur playable, although it doesn't mean full <source>
    support.
    est31 committed Oct 12, 2018
You can’t perform that action at this time.