Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the global entry url in Location::SetHref #21926

Closed
wants to merge 1 commit into from
Closed

Use the global entry url in Location::SetHref #21926

wants to merge 1 commit into from

Conversation

@Eijebong
Copy link
Member

Eijebong commented Oct 11, 2018 •
edited by nox

Now the /html/browsers/browsing-the-web/navigating-across-documents/005.htm test is intermittent too for the same reason as 006.htm.

See #21382.

Fixes #20906.

This change is Reviewable
@Eijebong
Use the global entry url in Location::SetHref
Loading status checks…
d30e9be 
Now the /html/browsers/browsing-the-web/navigating-across-documents/005.htm
test is itermittent too for the same reason as 006.htm
See #21382

Fixes #20906
@highfive
Copy link

highfive commented Oct 11, 2018

Heads up! This PR modifies the following files:
@jdm
Copy link
Member

jdm commented Oct 12, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Oct 12, 2018

📌 Commit d30e9be has been approved by jdm
@highfive highfive assigned jdm and unassigned emilio Oct 12, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Oct 12, 2018

⌛ Testing commit d30e9be with merge 8a11c28...
bors-servo added a commit that referenced this pull request Oct 12, 2018
@bors-servo
Auto merge of #21926 - Eijebong:set_href, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8a11c28 
Use the global entry url in Location::SetHref

Now the /html/browsers/browsing-the-web/navigating-across-documents/005.htm
test is itermittent too for the same reason as 006.htm
See #21382

Fixes #20906

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21926)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 12, 2018

💔 Test failed - linux-rel-wpt
@Eijebong
Copy link
Member Author

Eijebong commented Oct 12, 2018

Not sure about that, it's half new passing tests half new broken tests... I'll have a look tonight
@jdm
Copy link
Member

jdm commented Oct 17, 2018

@bors-servo r-
@bors-servo
Copy link
Contributor

bors-servo commented Apr 26, 2019

☔ The latest upstream changes (presumably #23090) made this pull request unmergeable. Please resolve the merge conflicts.
@Eijebong Eijebong closed this Nov 25, 2019
@jdm jdm mentioned this pull request Nov 25, 2019
Open
@jdm jdm mentioned this pull request Dec 4, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-needs-rebase S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Fix Location.SetHref for Iframe with no src
5 participants
@Eijebong @highfive @jdm @bors-servo @emilio
You can’t perform that action at this time.