Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Origin::unicode_serialization #21927

Merged
merged 1 commit into from Oct 13, 2018
Merged

Remove Origin::unicode_serialization #21927

merged 1 commit into from Oct 13, 2018
+3 −35

Conversation

@Eijebong
Copy link
Member

Eijebong commented Oct 11, 2018 •
edited by SimonSapin

Fixes #20701

This change is Reviewable
@highfive
Copy link

highfive commented Oct 11, 2018

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/eventsource.rs, components/script/dom/htmlanchorelement.rs
  • @KiChjang: components/script/dom/eventsource.rs, components/net_traits/blob_url_store.rs, components/script/dom/htmlanchorelement.rs
@jdm
Copy link
Member

jdm commented Oct 11, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Oct 11, 2018

📌 Commit 1741003 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Oct 12, 2018

⌛ Testing commit 1741003 with merge 275a13c...
bors-servo added a commit that referenced this pull request Oct 12, 2018
@bors-servo
Auto merge of #21927 - Eijebong:unicode_serialization, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
275a13c 
Remove Origin::unicode_serialization

Fixes #20701

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21927)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 12, 2018

💔 Test failed - linux-rel-wpt
@jdm
Copy link
Member

jdm commented Oct 12, 2018 

  ▶ Unexpected subtest result in /url/a-element-origin.html:
  └ PASS [expected FAIL] Parsing origin: <http://\u4f60\u597d\u4f60\u597d> against <http://other.com/>

  ▶ Unexpected subtest result in /url/a-element-origin.html:
  └ PASS [expected FAIL] Parsing origin: <ftp://%e2%98%83> against <about:blank>

  ▶ Unexpected subtest result in /url/a-element-origin.html:
  └ PASS [expected FAIL] Parsing origin: <https://%e2%98%83> against <about:blank>

  ▶ Unexpected subtest result in /url/a-element-origin-xhtml.xhtml:
  └ PASS [expected FAIL] Parsing origin: <http://\u4f60\u597d\u4f60\u597d> against <http://other.com/>

  ▶ Unexpected subtest result in /url/a-element-origin-xhtml.xhtml:
  └ PASS [expected FAIL] Parsing origin: <ftp://%e2%98%83> against <about:blank>

  ▶ Unexpected subtest result in /url/a-element-origin-xhtml.xhtml:
  └ PASS [expected FAIL] Parsing origin: <https://%e2%98%83> against <about:blank>
@Eijebong
Remove Origin::unicode_serialization
Loading status checks…
a97ba4f 
Fixes #20701
@Eijebong Eijebong force-pushed the Eijebong:unicode_serialization branch from 1741003 to a97ba4f Oct 12, 2018
@Eijebong
Copy link
Member Author

Eijebong commented Oct 12, 2018

Fixed expectations
@jdm
Copy link
Member

jdm commented Oct 12, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Oct 12, 2018

📌 Commit a97ba4f has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Oct 12, 2018

⌛ Testing commit a97ba4f with merge 49a3554...
bors-servo added a commit that referenced this pull request Oct 12, 2018
@bors-servo
Auto merge of #21927 - Eijebong:unicode_serialization, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
49a3554 
Remove Origin::unicode_serialization

Fixes #20701

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21927)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 12, 2018

💔 Test failed - linux-rel-css
@jdm
Copy link
Member

jdm commented Oct 13, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Oct 13, 2018

⌛ Testing commit a97ba4f with merge a9eaed4...
bors-servo added a commit that referenced this pull request Oct 13, 2018
@bors-servo
Auto merge of #21927 - Eijebong:unicode_serialization, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a9eaed4 
Remove Origin::unicode_serialization

Fixes #20701

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21927)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 13, 2018

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, status-taskcluster, windows-msvc-dev
Approved by: jdm
Pushing a9eaed4 to master...
@bors-servo bors-servo merged commit a97ba4f into servo:master Oct 13, 2018
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@Eijebong @highfive @jdm @bors-servo
You can’t perform that action at this time.