New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevTools - add preliminary StyleSheetActor #21941

Merged
merged 1 commit into from Oct 14, 2018

Conversation

Projects
None yet
5 participants
@codehag
Contributor

codehag commented Oct 14, 2018

Based on an error coming from devtools, that the server did not support a stylesheets actor, this patch introduces a StyleSheetsActor. It has no methods yet, but it is a small step towards getting the devtools up and running.

Before the change:
No stylesheet editor

After the change we can see that the style editor now loads. It has no information but I will get to that later.
screen shot 2018-10-14 at 12 51 51

Status after this PR:

  • Debugger does not load
  • Netmonitor does not load
  • Console is loading but doesn't receive messages.
  • Inspector is, but does not have any information
  • style editor is now loading but does not have any information
  • Performance is an out of date tab, and will likely need to be changed substantially

next steps for this will be to implement the protocol methods

I am not too sure how to test this, it doesn't look like there are tests yet for the devtools, is that right?


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable

@highfive

This comment has been minimized.

highfive commented Oct 14, 2018

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @ferjm (or someone else) soon.

@jdm

This comment has been minimized.

Member

jdm commented Oct 14, 2018

Correct; we haven't figured out a way to write meaningful tests for the devtools server.

@@ -65,6 +66,7 @@ mod actors {
pub mod performance;
pub mod profiler;
pub mod root;
pub mod styleSheets;

This comment has been minimized.

@jdm

jdm Oct 14, 2018

Member

stylesheets

@@ -33,6 +33,7 @@ use actors::network_event::{EventActor, NetworkEventActor, ResponseStartMsg};
use actors::performance::PerformanceActor;
use actors::profiler::ProfilerActor;
use actors::root::RootActor;
use actors::styleSheets::StyleSheetsActor;

This comment has been minimized.

@jdm

jdm Oct 14, 2018

Member

stylesheets

@codehag codehag force-pushed the codehag:devtools-add-stylesheets-actor branch from 6ccab14 to c88cc3e Oct 14, 2018

@codehag

This comment has been minimized.

Contributor

codehag commented Oct 14, 2018

@jdm if we were to introduce tests, would adding a folder to tests/unit/ for devtools be a good place to start? that way I could start introducing unit tests.

@jdm

This comment has been minimized.

Member

jdm commented Oct 14, 2018

That would be a fine place.

@jdm

This comment has been minimized.

Member

jdm commented Oct 14, 2018

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 14, 2018

📌 Commit c88cc3e has been approved by jdm

@highfive highfive assigned jdm and unassigned ferjm Oct 14, 2018

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 14, 2018

⌛️ Testing commit c88cc3e with merge f3533b4...

bors-servo added a commit that referenced this pull request Oct 14, 2018

Auto merge of #21941 - codehag:devtools-add-stylesheets-actor, r=jdm
DevTools - add preliminary StyleSheetActor

Based on an error coming from devtools, that the server did not support a stylesheets actor, this patch introduces a [StyleSheetsActor](https://searchfox.org/mozilla-central/rev/26b40a44691e0710838130b614c2f2662bc91eec/devtools/server/actors/stylesheets.js#590-853). It has no methods yet, but it is a small step towards getting the devtools up and running.

Before the change:
No stylesheet editor

After the change we can see that the style editor now loads. It has no information but I will get to that later.
<img width="902" alt="screen shot 2018-10-14 at 12 51 51" src="https://user-images.githubusercontent.com/26968615/46915813-61192900-cfb1-11e8-8382-3d9dc8db4114.png">

Status after this PR:
* Debugger does not load
* Netmonitor does not load
* Console is loading but doesn't receive messages.
* Inspector is, but does not have any information
* style editor is *now loading* but does not have any information
* Performance is an out of date tab, and will likely need to be changed substantially

next steps for this will be to implement the [protocol methods](https://searchfox.org/mozilla-central/source/devtools/shared/specs/stylesheets.js#74-95)

I am not too sure how to test this, it doesn't look like there are tests yet for the devtools, is that right?

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21941)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 14, 2018

💔 Test failed - mac-rel-css1

@jdm

This comment has been minimized.

Member

jdm commented Oct 14, 2018

@bors-servo retry

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 14, 2018

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 14, 2018

@bors-servo bors-servo merged commit c88cc3e into servo:master Oct 14, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@bors-servo bors-servo referenced this pull request Oct 14, 2018

Merged

DevTools - add Emulation Actor #21945

2 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment