New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevTools - add Emulation Actor #21945

Merged
merged 1 commit into from Oct 15, 2018

Conversation

Projects
None yet
5 participants
@codehag
Contributor

codehag commented Oct 14, 2018

Last one for today, this one adds the Emulation actor, which allows the netmonitor panel to load. The emulation actor has no methods for now, but will eventually be used by the netmonitor to throttle connections.

Currently the netmonitor shows but doesn't have any values. will get to that soon!

screen shot 2018-10-14 at 19 26 16

Combined with the changes for the stylesheets actor, the device actor, and the extra methods added in browserContext and threadActor, the devtools are now all loading \o/


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable

@highfive

This comment has been minimized.

highfive commented Oct 14, 2018

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @jdm (or someone else) soon.

@codehag codehag force-pushed the codehag:devtools-add-emulation-actor branch from 5ceade1 to 831c9eb Oct 14, 2018

@jdm

This comment has been minimized.

Member

jdm commented Oct 14, 2018

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 14, 2018

📌 Commit 831c9eb has been approved by jdm

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 14, 2018

☔️ The latest upstream changes (presumably #21941) made this pull request unmergeable. Please resolve the merge conflicts.

@KiChjang

This comment has been minimized.

Member

KiChjang commented Oct 14, 2018

@codehag mind rebasing your commits instead?

@codehag codehag force-pushed the codehag:devtools-add-emulation-actor branch from 217ac67 to 9ccf7c0 Oct 15, 2018

@codehag

This comment has been minimized.

Contributor

codehag commented Oct 15, 2018

Done!

@KiChjang

This comment has been minimized.

Member

KiChjang commented Oct 15, 2018

@bors-servo r=jdm

Thanks!

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 15, 2018

📌 Commit 9ccf7c0 has been approved by jdm

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 15, 2018

⌛️ Testing commit 9ccf7c0 with merge d22b103...

bors-servo added a commit that referenced this pull request Oct 15, 2018

Auto merge of #21945 - codehag:devtools-add-emulation-actor, r=jdm
DevTools - add Emulation Actor

Last one for today, this one adds the Emulation actor, which allows the netmonitor panel to load. The emulation actor has no methods for now, but will eventually be used by the netmonitor to throttle connections.

Currently the netmonitor shows but doesn't have any values. will get to that soon!

<img width="901" alt="screen shot 2018-10-14 at 19 26 16" src="https://user-images.githubusercontent.com/26968615/46920018-30a0b180-cfe8-11e8-83ec-51ca71f0e8c3.png">

Combined with the changes for the stylesheets actor, the device actor, and the extra methods added in browserContext and threadActor, the devtools are now all loading \o/

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21945)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 15, 2018

💔 Test failed - linux-rel-css

@jdm

This comment has been minimized.

Member

jdm commented Oct 15, 2018

@bors-servo retry

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 15, 2018

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 15, 2018

@bors-servo bors-servo merged commit 9ccf7c0 into servo:master Oct 15, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment