Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement CharacterData.{deleteData, insertData, replaceData}.(fixes #2190) #2195

Merged
merged 1 commit into from Apr 21, 2014

Conversation

@lpy
Copy link
Contributor

lpy commented Apr 20, 2014

see #2190

@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Apr 20, 2014

Critic review: https://critic.hoppipolla.co.uk/r/1332

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on fd95413 Apr 21, 2014

This comment has been minimized.

Copy link
Contributor

bors-servo replied Apr 21, 2014

merging lpy/servo/issue2190 = fd95413 into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Apr 21, 2014

lpy/servo/issue2190 = fd95413 merged ok, testing candidate = 3c175c7

This comment has been minimized.

Copy link
Contributor

bors-servo replied Apr 21, 2014

fast-forwarding master to auto = 3c175c7

bors-servo pushed a commit that referenced this pull request Apr 21, 2014
@bors-servo bors-servo merged commit fd95413 into servo:master Apr 21, 2014
1 check passed
1 check passed
default all tests passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.