Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement CharacterData.{deleteData, insertData, replaceData}.(fixes #2190) #2195
Conversation
hoppipolla-critic-bot
commented
Apr 20, 2014
|
Critic review: https://critic.hoppipolla.co.uk/r/1332 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
This comment has been minimized.
This comment has been minimized.
|
saw approval from Ms2ger |
This comment has been minimized.
This comment has been minimized.
|
merging lpy/servo/issue2190 = fd95413 into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
all tests pass: |
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = 3c175c7 |
fd95413
into
servo:master
lpy commentedApr 20, 2014
see #2190