Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMake android logging work for multiple println calls #21950
Merged
Conversation
highfive
commented
Oct 15, 2018
|
|
|
@bors-servo r+ PogChamp |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 15, 2018
Make android logging work for multiple println calls
The existing implementation had incorrect calculations for calculating when there was unlogged data sitting in the buffer and when the buffer was full. With these changes I am able to see the expected output for the following testcase:
```html
<script>
console.log("hi");
console.log("hi there");
console.log("hi there again");
let s = "hi there again x2 ";
for (var i = 0; i < 10; i++) {
s += s;
}
console.log(s);
</script>
```
---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #21875
- [x] These changes do not require tests because no automated tests for behaviour of logcat on android
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21950)
<!-- Reviewable:end -->
|
|
|
@bors-servo r=nox |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 15, 2018
Make android logging work for multiple println calls
The existing implementation had incorrect calculations for calculating when there was unlogged data sitting in the buffer and when the buffer was full. With these changes I am able to see the expected output for the following testcase:
```html
<script>
console.log("hi");
console.log("hi there");
console.log("hi there again");
let s = "hi there again x2 ";
for (var i = 0; i < 10; i++) {
s += s;
}
console.log(s);
</script>
```
---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #21875
- [x] These changes do not require tests because no automated tests for behaviour of logcat on android
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21950)
<!-- Reviewable:end -->
|
|
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 15, 2018
Make android logging work for multiple println calls
The existing implementation had incorrect calculations for calculating when there was unlogged data sitting in the buffer and when the buffer was full. With these changes I am able to see the expected output for the following testcase:
```html
<script>
console.log("hi");
console.log("hi there");
console.log("hi there again");
let s = "hi there again x2 ";
for (var i = 0; i < 10; i++) {
s += s;
}
console.log(s);
</script>
```
---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #21875
- [x] These changes do not require tests because no automated tests for behaviour of logcat on android
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21950)
<!-- Reviewable:end -->
|
|
|
@bors-servo retry
|
bors-servo
added a commit
that referenced
this pull request
Oct 15, 2018
Make android logging work for multiple println calls
The existing implementation had incorrect calculations for calculating when there was unlogged data sitting in the buffer and when the buffer was full. With these changes I am able to see the expected output for the following testcase:
```html
<script>
console.log("hi");
console.log("hi there");
console.log("hi there again");
let s = "hi there again x2 ";
for (var i = 0; i < 10; i++) {
s += s;
}
console.log(s);
</script>
```
---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #21875
- [x] These changes do not require tests because no automated tests for behaviour of logcat on android
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21950)
<!-- Reviewable:end -->
|
|
|
Output is still not showing. |
|
This did not make the nightly build, if that's what you're testing. |
|
Nah I just forgot to reinstall the app on my device. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jdm commentedOct 15, 2018
•
edited by SimonSapin
The existing implementation had incorrect calculations for calculating when there was unlogged data sitting in the buffer and when the buffer was full. With these changes I am able to see the expected output for the following testcase:
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is