Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the right flags and attributes for InitEvent #2196

Merged
merged 1 commit into from Apr 21, 2014

Conversation

@hmac
Copy link
Contributor

hmac commented Apr 20, 2014

Should fix #2189

This is my first PR for servo (and first time using Rust), so apologies if anything is horribly wrong.

@highfive
Copy link

highfive commented Apr 20, 2014

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @metajack (or someone else) soon.

@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Apr 20, 2014

Critic review: https://critic.hoppipolla.co.uk/r/1333

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@Ms2ger
Copy link
Contributor

Ms2ger commented Apr 21, 2014

Went perfectly, thanks!

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on 7dbf69c Apr 21, 2014

This comment has been minimized.

Copy link
Contributor

bors-servo replied Apr 21, 2014

merging hazz/servo/initevent = 7dbf69c into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Apr 21, 2014

hazz/servo/initevent = 7dbf69c merged ok, testing candidate = 73a0658

This comment has been minimized.

Copy link
Contributor

bors-servo replied Apr 21, 2014

fast-forwarding master to auto = 73a0658

bors-servo pushed a commit that referenced this pull request Apr 21, 2014
Should fix #2189

This is my first PR for servo (and first time using Rust), so apologies if anything is horribly wrong.
@bors-servo bors-servo merged commit 7dbf69c into servo:master Apr 21, 2014
1 check passed
1 check passed
default all tests passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can’t perform that action at this time.