Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSet the right flags and attributes for InitEvent #2196
Conversation
highfive
commented
Apr 20, 2014
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @metajack (or someone else) soon. |
hoppipolla-critic-bot
commented
Apr 20, 2014
|
Critic review: https://critic.hoppipolla.co.uk/r/1333 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
Went perfectly, thanks! |
This comment has been minimized.
This comment has been minimized.
|
saw approval from Ms2ger |
This comment has been minimized.
This comment has been minimized.
|
merging hazz/servo/initevent = 7dbf69c into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
all tests pass: |
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = 73a0658 |
7dbf69c
into
servo:master
hmac commentedApr 20, 2014
Should fix #2189
This is my first PR for servo (and first time using Rust), so apologies if anything is horribly wrong.