Windows: Add missing dependencies #21968

UK992 · 2018-10-16T22:08:01Z

Rebased #16445 and updated with Gstreamer DLLs.

About msi installer, there is also included gstreamer installer, should be removed and replaced by needed gstreamer DLLs or keep it at is it?

Fixes #16422.

This change is

highfive · 2018-10-16T22:08:05Z

Heads up! This PR modifies the following files:

@wafflespeanut: python/servo/command_base.py, python/servo/build_commands.py, python/servo/package_commands.py

jdm · 2018-11-27T16:54:43Z

@bors-servo r+
Looks good! Sorry for the delay in reviewing these changes.

bors-servo · 2018-11-27T16:54:44Z

📌 Commit a31c8d7 has been approved by jdm

bors-servo · 2018-11-27T17:56:21Z

⌛ Testing commit a31c8d7 with merge 02d30fa...


        Auto merge of #21968 - UK992:mach-package, r=jdm

Windows: Add missing dependencies Rebased #16445 and updated with Gstreamer DLLs. About msi installer, there is also included gstreamer installer, should be removed and replaced by needed gstreamer DLLs or keep it at is it?  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21968)

bors-servo · 2018-11-27T18:30:42Z

💔 Test failed - windows-msvc-dev

jdm · 2018-11-27T18:35:30Z

Error running mach:

    ['build', '--dev']

The error occurred in the implementation of the invoked mach command.

This should never occur and is likely a bug in the implementation of that
command. Consider filing a bug for this issue.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

KeyError: u'GSTREAMER_1_0_ROOT_X86_64'

  File "c:\buildbot\windows-msvc-dev\build\python\servo\build_commands.py", line 591, in build
    gst_root = env["GSTREAMER_1_0_ROOT_" + gst_x64]
program finished with exit code 1

Where is that environment variable supposed to come from?

UK992 · 2018-12-01T16:16:17Z

@jdm Gstreamer installer set this variable.

atouchet · 2018-12-01T20:04:39Z

Would this help with #22315?

UK992 · 2018-12-01T22:03:51Z

@atouchet it should solve this issue.

Also I removed GStreamer installer from package, because it is no longer needed.


        Windows: Add missing dependencies


        Package: Update zip file creation


        Package: Update Windows packaging


        Remove GStreamer installer from Servo bundle

atouchet · 2018-12-08T21:03:37Z

@jdm r?

jdm · 2018-12-13T16:06:55Z

Ok, so let's be clear - the effect of this change is that:

we generate an EXE instead of an MSI
we no longer run the official GStreamer installer during the installation
the installer contains all of the known DLL dependencies of Servo, including the GStreamer ones

Is that correct?


        Auto merge of #21968 - UK992:mach-package, r=<try>

Windows: Add missing dependencies Rebased #16445 and updated with Gstreamer DLLs. About msi installer, there is also included gstreamer installer, should be removed and replaced by needed gstreamer DLLs or keep it at is it? Fixes #16422.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21968)

bors-servo · 2019-02-01T20:56:57Z

💔 Test failed - status-taskcluster

UK992 · 2019-02-01T21:08:43Z

@jdm try again please

Added missing gstreamer-1.0-x86_64-1.14.3.msi which contain needed dlls.

jdm · 2019-02-01T21:21:34Z

@bors-servo try=windows

bors-servo · 2019-02-01T21:22:19Z

⌛ Trying commit dc2cc29 with merge e21757f...


        Auto merge of #21968 - UK992:mach-package, r=<try>

Windows: Add missing dependencies Rebased #16445 and updated with Gstreamer DLLs. About msi installer, there is also included gstreamer installer, should be removed and replaced by needed gstreamer DLLs or keep it at is it? Fixes #16422.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21968)

bors-servo · 2019-02-01T21:29:09Z

💔 Test failed - status-taskcluster


        Taskcluster: Install gstreamer-1.0-x86_64-1.14.3.msi

UK992 · 2019-02-01T21:44:29Z

Installing gstreamer-1.0-x86_64-1.14.3.msi and setting GSTREAMER_1_0_ROOT_X86_64 environment variable seems to solve the problem with Gstreamer.

But adding another .with_repacked_msi() in etc/taskcluster/decision_task.py creates new task in TC.

jdm · 2019-02-01T21:46:35Z

@bors-servo r+
LGTM! Thanks for fixing that!

SimonSapin · 2019-02-01T22:26:50Z

Creating new tasks is ok, and output of the MSI ones is cached so they’ll only run again when caches expire.

atouchet · 2019-02-01T22:53:12Z

@jdm I don't think that worked. Retry?

bors-servo · 2019-02-01T23:02:56Z

📌 Commit f374dc3 has been approved by jdm

bors-servo · 2019-02-01T23:03:00Z

⌛ Testing commit f374dc3 with merge 3630735...


        Auto merge of #21968 - UK992:mach-package, r=jdm

Windows: Add missing dependencies Rebased #16445 and updated with Gstreamer DLLs. About msi installer, there is also included gstreamer installer, should be removed and replaced by needed gstreamer DLLs or keep it at is it? Fixes #16422.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21968)

bors-servo · 2019-02-02T00:22:09Z

☀️ Test successful - android-mac, arm32, arm64, linux-rel-css, linux-rel-wpt, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster
Approved by: jdm
Pushing 3630735 to master...

atouchet · 2019-02-02T03:56:44Z

I tried running the latest nightly without having GStreamer installed and got some errors about missing DLLs.

jdm · 2019-02-02T12:57:08Z

Those will need to be added to the list of included DLLs.


        Auto merge of #22811 - UK992:mach-package-2, r=jdm

@jdm

Windows: Add more missing dependencies From #21968 (comment) r? @jdm cc @atouchet  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22811)

highfive assigned ferjm Oct 16, 2018

highfive added the S-awaiting-review label Oct 16, 2018

highfive assigned jdm and unassigned ferjm Nov 27, 2018

highfive added S-awaiting-merge and removed S-awaiting-review labels Nov 27, 2018

highfive added S-tests-failed and removed S-awaiting-merge labels Nov 27, 2018

UK992 force-pushed the UK992:mach-package branch from a31c8d7 to 75aa241 Dec 1, 2018

highfive added S-awaiting-review and removed S-tests-failed labels Dec 1, 2018

atouchet mentioned this pull request Dec 1, 2018

Windows nightly crashes on startup for some users #22315

Closed

UK992 added 4 commits Oct 16, 2018

Windows: Add missing dependencies

f4d3d8e

Package: Update zip file creation

c4b5c94

Package: Update Windows packaging

0691045

Remove GStreamer installer from Servo bundle

Loading status checks…

d929428

UK992 force-pushed the UK992:mach-package branch from 2ee2223 to d929428 Dec 1, 2018

jdm added the S-awaiting-answer label Dec 13, 2018

highfive added S-tests-failed and removed S-tests-failed labels Feb 1, 2019

highfive added the S-tests-failed label Feb 1, 2019

Taskcluster: Install gstreamer-1.0-x86_64-1.14.3.msi

Loading status checks…

f374dc3

UK992 force-pushed the UK992:mach-package branch from dc2cc29 to f374dc3 Feb 1, 2019

highfive removed the S-tests-failed label Feb 1, 2019

highfive added S-awaiting-merge and removed S-awaiting-review labels Feb 1, 2019

bors-servo merged commit f374dc3 into servo:master Feb 2, 2019
2 of 3 checks passed

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details

Travis CI - Pull Request Build Passed
Details

homu Test successful
Details

highfive removed the S-awaiting-merge label Feb 2, 2019

UK992 mentioned this pull request Feb 2, 2019

Windows: Add more missing dependencies #22811

Merged

atouchet mentioned this pull request Feb 3, 2019

64-bit Windows requires 32-bit GStreamer #22778

Open

servo / servo

Windows: Add missing dependencies #21968

Windows: Add missing dependencies #21968

UK992 commented Oct 16, 2018 •

edited by atouchet

highfive commented Oct 16, 2018

jdm commented Nov 27, 2018

bors-servo commented Nov 27, 2018

bors-servo commented Nov 27, 2018

bors-servo commented Nov 27, 2018

jdm commented Nov 27, 2018

UK992 commented Dec 1, 2018

atouchet commented Dec 1, 2018

UK992 commented Dec 1, 2018

atouchet commented Dec 8, 2018

jdm commented Dec 13, 2018 •

edited

bors-servo commented Feb 1, 2019

UK992 commented Feb 1, 2019

jdm commented Feb 1, 2019

bors-servo commented Feb 1, 2019

bors-servo commented Feb 1, 2019

UK992 commented Feb 1, 2019

jdm commented Feb 1, 2019

SimonSapin commented Feb 1, 2019

atouchet commented Feb 1, 2019

bors-servo commented Feb 1, 2019

bors-servo commented Feb 1, 2019

bors-servo commented Feb 2, 2019

atouchet commented Feb 2, 2019

jdm commented Feb 2, 2019 •

edited

servo / servo

Join GitHub today

Windows: Add missing dependencies #21968

Windows: Add missing dependencies #21968

Conversation

UK992 commented Oct 16, 2018 • edited by atouchet

highfive commented Oct 16, 2018

jdm commented Nov 27, 2018

bors-servo commented Nov 27, 2018

bors-servo commented Nov 27, 2018

bors-servo commented Nov 27, 2018

jdm commented Nov 27, 2018

UK992 commented Dec 1, 2018

atouchet commented Dec 1, 2018

UK992 commented Dec 1, 2018

atouchet commented Dec 8, 2018

jdm commented Dec 13, 2018 • edited

bors-servo commented Feb 1, 2019

UK992 commented Feb 1, 2019

jdm commented Feb 1, 2019

bors-servo commented Feb 1, 2019

bors-servo commented Feb 1, 2019

UK992 commented Feb 1, 2019

jdm commented Feb 1, 2019

SimonSapin commented Feb 1, 2019

atouchet commented Feb 1, 2019

bors-servo commented Feb 1, 2019

bors-servo commented Feb 1, 2019

bors-servo commented Feb 2, 2019

atouchet commented Feb 2, 2019

jdm commented Feb 2, 2019 • edited

UK992 commented Oct 16, 2018 •

edited by atouchet

jdm commented Dec 13, 2018 •

edited

jdm commented Feb 2, 2019 •

edited