Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSplit background.rs file in background, border and gradient #21972
Conversation
highfive
commented
Oct 17, 2018
|
Heads up! This PR modifies the following files:
|
highfive
commented
Oct 17, 2018
|
|
|
@bors-servo r+ |
|
|
Split background.rs file in background, border and gradient I happened to read a style guide and found that many people use short function names but import only the parent module so the function is called gradient::linear instead of create_linear_gradient. (I usually prefix my function names with a verb but this does not appear to be the preferred style) In the layout crate files quite often contain the line `#![deny(unsafe_code)]` but writing it once in `lib.rs` should suffice. Finally the Webrender DisplayListBuilder is now bypassed for some items and they are directly pushed to the display list. (See #19676) <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21972) <!-- Reviewable:end -->
|
|
|
A lot of output like: |
|
@bors-servo r- |
|
@bors-servo test=wpt Had made an embarrassing mistake, should be fine now. |
|
@bors-servo r+ |
|
|
Split background.rs file in background, border and gradient I happened to read a style guide and found that many people use short function names but import only the parent module so the function is called gradient::linear instead of create_linear_gradient. (I usually prefix my function names with a verb but this does not appear to be the preferred style) In the layout crate files quite often contain the line `#![deny(unsafe_code)]` but writing it once in `lib.rs` should suffice. Finally the Webrender DisplayListBuilder is now bypassed for some items and they are directly pushed to the display list. (See #19676) <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21972) <!-- Reviewable:end -->
|
|
|
(@bors-servo retry) Not sure how to restart bors. Failures are AFAIK unrelated. |
|
@bors-servo retry |
Add license to two files. Bypass DisplayListBuilder for some items.
|
@bors-servo try=wpt Bug fixed, rebased. |
|
rebased, bug fixed @bors-servo try=wpt |
|
@bors-servo retry |
Split background.rs file in background, border and gradient I happened to read a style guide and found that many people use short function names but import only the parent module so the function is called gradient::linear instead of create_linear_gradient. (I usually prefix my function names with a verb but this does not appear to be the preferred style) In the layout crate files quite often contain the line `#![deny(unsafe_code)]` but writing it once in `lib.rs` should suffice. Finally the Webrender DisplayListBuilder is now bypassed for some items and they are directly pushed to the display list. (See #19676) <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21972) <!-- Reviewable:end -->
That was the only failure. |
Split background.rs file in background, border and gradient I happened to read a style guide and found that many people use short function names but import only the parent module so the function is called gradient::linear instead of create_linear_gradient. (I usually prefix my function names with a verb but this does not appear to be the preferred style) In the layout crate files quite often contain the line `#![deny(unsafe_code)]` but writing it once in `lib.rs` should suffice. Finally the Webrender DisplayListBuilder is now bypassed for some items and they are directly pushed to the display list. (See #19676) <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21972) <!-- Reviewable:end -->
|
This time it was: |
|
@bors-servo r+ |
|
|
Split background.rs file in background, border and gradient I happened to read a style guide and found that many people use short function names but import only the parent module so the function is called gradient::linear instead of create_linear_gradient. (I usually prefix my function names with a verb but this does not appear to be the preferred style) In the layout crate files quite often contain the line `#![deny(unsafe_code)]` but writing it once in `lib.rs` should suffice. Finally the Webrender DisplayListBuilder is now bypassed for some items and they are directly pushed to the display list. (See #19676) <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21972) <!-- Reviewable:end -->
|
|
6 similar comments
|
|
|
|
|
|
|
|
|
|
|
|
pyfisch commentedOct 17, 2018
•
edited by SimonSapin
I happened to read a style guide and found that many people use short function names but import only the parent module so the function is called gradient::linear instead of create_linear_gradient. (I usually prefix my function names with a verb but this does not appear to be the preferred style)
In the layout crate files quite often contain the line
#![deny(unsafe_code)]but writing it once inlib.rsshould suffice.Finally the Webrender DisplayListBuilder is now bypassed for some items and they are directly pushed to the display list. (See #19676)
This change is