New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly determine text selection direction #21975

Merged
merged 1 commit into from Oct 18, 2018

Conversation

Projects
None yet
5 participants
@pyfisch
Contributor

pyfisch commented Oct 17, 2018

Add some debug! output.

Closes #21891


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #21891 (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable

Correctly determine text selection direction
Add some debug! output.

Closes #21891
@highfive

This comment has been minimized.

highfive commented Oct 17, 2018

Heads up! This PR modifies the following files:

@highfive

This comment has been minimized.

highfive commented Oct 17, 2018

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@pyfisch

This comment has been minimized.

Contributor

pyfisch commented Oct 17, 2018

@bors-servo try=wpt

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 17, 2018

⌛️ Trying commit c2ea135 with merge 50a85a6...

bors-servo added a commit that referenced this pull request Oct 17, 2018

Auto merge of #21975 - pyfisch:fix-selection, r=<try>
Correctly determine text selection direction

Add some debug! output.

Closes #21891

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21975)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 17, 2018

💔 Test failed - linux-rel-wpt

@pyfisch

This comment has been minimized.

Contributor

pyfisch commented Oct 17, 2018

@bors-servo retry

I don't see how /css/cssom-view/elementFromPoint-001.html should be affected.

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 17, 2018

⌛️ Trying commit c2ea135 with merge c8f9f16...

bors-servo added a commit that referenced this pull request Oct 17, 2018

Auto merge of #21975 - pyfisch:fix-selection, r=<try>
Correctly determine text selection direction

Add some debug! output.

Closes #21891

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #21891 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21975)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 17, 2018

💔 Test failed - linux-rel-wpt

@pyfisch

This comment has been minimized.

Contributor

pyfisch commented Oct 17, 2018

@bors-servo retry

A different test fails.

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 17, 2018

⌛️ Trying commit c2ea135 with merge 62e49bb...

bors-servo added a commit that referenced this pull request Oct 17, 2018

Auto merge of #21975 - pyfisch:fix-selection, r=<try>
Correctly determine text selection direction

Add some debug! output.

Closes #21891

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #21891 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21975)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 17, 2018

☀️ Test successful - linux-rel-css, linux-rel-wpt
State: approved= try=True

@paulrouget

This comment has been minimized.

Contributor

paulrouget commented Oct 18, 2018

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 18, 2018

📌 Commit c2ea135 has been approved by paulrouget

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 18, 2018

⌛️ Testing commit c2ea135 with merge c3c6898...

bors-servo added a commit that referenced this pull request Oct 18, 2018

Auto merge of #21975 - pyfisch:fix-selection, r=paulrouget
Correctly determine text selection direction

Add some debug! output.

Closes #21891

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #21891 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21975)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 18, 2018

💔 Test failed - linux-rel-wpt

@jdm

This comment has been minimized.

Member

jdm commented Oct 18, 2018

@bors-servo retry

  • oom
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 18, 2018

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 18, 2018

@bors-servo bors-servo merged commit c2ea135 into servo:master Oct 18, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment