Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upstyle: Re-enable the rule that was accidentally disabled by a typo in the CSS parser. #21983
Conversation
|
@bors-servo try |
bors-servo
added a commit
that referenced
this pull request
Oct 18, 2018
style: Re-enable the rule that was accidentally disabled by a typo in the CSS parser. In #21946 I commented out this rule because before that patch we were accidentally ignoring it because of a typo in the CSS parser, since that PR didn't intend to change behavior. This PR does though, and re-enables the rule. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21983) <!-- Reviewable:end -->
|
|
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 31, 2018
style: Re-enable the rule that was accidentally disabled by a typo in the CSS parser. In #21946 I commented out this rule because before that patch we were accidentally ignoring it because of a typo in the CSS parser, since that PR didn't intend to change behavior. This PR does though, and re-enables the rule. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21983) <!-- Reviewable:end -->
|
|
|
@bors-servo retry
|
bors-servo
added a commit
that referenced
this pull request
Oct 31, 2018
style: Re-enable the rule that was accidentally disabled by a typo in the CSS parser. In #21946 I commented out this rule because before that patch we were accidentally ignoring it because of a typo in the CSS parser, since that PR didn't intend to change behavior. This PR does though, and re-enables the rule. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21983) <!-- Reviewable:end -->
|
|
|
@bors-servo retry
|
bors-servo
added a commit
that referenced
this pull request
Oct 31, 2018
style: Re-enable the rule that was accidentally disabled by a typo in the CSS parser. In #21946 I commented out this rule because before that patch we were accidentally ignoring it because of a typo in the CSS parser, since that PR didn't intend to change behavior. This PR does though, and re-enables the rule. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21983) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Oct 31, 2018
style: Re-enable the rule that was accidentally disabled by a typo in the CSS parser. In #21946 I commented out this rule because before that patch we were accidentally ignoring it because of a typo in the CSS parser, since that PR didn't intend to change behavior. This PR does though, and re-enables the rule. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21983) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
emilio commentedOct 18, 2018
•
edited by SimonSapin
In #21946 I commented out this rule because before that patch we were
accidentally ignoring it because of a typo in the CSS parser, since that PR
didn't intend to change behavior.
This PR does though, and re-enables the rule.
This change is