Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Element.prefix (Fixes #1737) #2199

Merged
merged 1 commit into from Apr 21, 2014
Merged

Conversation

@ngsankha
Copy link
Contributor

ngsankha commented Apr 21, 2014

See #1737.

r? @Ms2ger

@highfive
Copy link

highfive commented Apr 21, 2014

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @metajack (or someone else) soon.

@lpy lpy mentioned this pull request Apr 21, 2014
@Ms2ger Ms2ger closed this Apr 21, 2014
@Ms2ger Ms2ger reopened this Apr 21, 2014
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Apr 21, 2014

Critic review: https://critic.hoppipolla.co.uk/r/1340

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@Ms2ger

This comment has been minimized.

Copy link

Ms2ger commented on 36bf23d Apr 21, 2014

r+

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on 36bf23d Apr 21, 2014

saw approval from Ms2ger
at ngsankha@36bf23d

This comment has been minimized.

Copy link
Contributor

bors-servo replied Apr 21, 2014

merging sankha93/servo/prefix-impl = 36bf23d into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Apr 21, 2014

sankha93/servo/prefix-impl = 36bf23d merged ok, testing candidate = c760577

This comment has been minimized.

Copy link
Contributor

bors-servo replied Apr 21, 2014

fast-forwarding master to auto = c760577

bors-servo pushed a commit that referenced this pull request Apr 21, 2014
@bors-servo bors-servo merged commit 36bf23d into servo:master Apr 21, 2014
1 check passed
1 check passed
default all tests passed
@ngsankha ngsankha deleted the ngsankha:prefix-impl branch Apr 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.