Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement Element.prefix (Fixes #1737) #2199
Conversation
highfive
commented
Apr 21, 2014
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @metajack (or someone else) soon. |
hoppipolla-critic-bot
commented
Apr 21, 2014
|
Critic review: https://critic.hoppipolla.co.uk/r/1340 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
This comment has been minimized.
This comment has been minimized.
Ms2ger
commented on 36bf23d
Apr 21, 2014
|
r+ |
This comment has been minimized.
This comment has been minimized.
|
saw approval from Ms2ger |
This comment has been minimized.
This comment has been minimized.
|
merging sankha93/servo/prefix-impl = 36bf23d into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
all tests pass: |
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = c760577 |
36bf23d
into
servo:master
ngsankha commentedApr 21, 2014
See #1737.
r? @Ms2ger