Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update servo-media #21999

Merged
merged 1 commit into from Oct 23, 2018
Merged

Update servo-media #21999

merged 1 commit into from Oct 23, 2018
+14 −8

Conversation

@asajeffrey
Copy link
Member

asajeffrey commented Oct 22, 2018 •
edited by SimonSapin

Get servo to compile against servo-media master.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes do not require tests because updating a dependency

This change is Reviewable
@asajeffrey
Copy link
Member Author

asajeffrey commented Oct 22, 2018

r? @ferjm
@asajeffrey asajeffrey mentioned this pull request Oct 22, 2018
Merged
3 of 3 tasks complete
@ferjm
Copy link
Member

ferjm commented Oct 22, 2018

@bors-servo r+
@asajeffrey
Copy link
Member Author

asajeffrey commented Oct 22, 2018

GitHub webooks were down due to https://blog.github.com/2018-10-21-october21-incident-report/, so bors wasn't getting notifications. Let's see if it's fixed now...

@bors-servo r=ferjm
@jdm
Copy link
Member

jdm commented Oct 22, 2018

@bors-servo ping
1 similar comment
@jdm
Copy link
Member

jdm commented Oct 22, 2018

@bors-servo ping
@highfive
Copy link

highfive commented Oct 22, 2018

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/htmlmediaelement.rs
@highfive
Copy link

highfive commented Oct 22, 2018

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@bors-servo
Copy link
Contributor

bors-servo commented Oct 22, 2018

📌 Commit 950512d has been approved by ferjm
1 similar comment
@bors-servo
Copy link
Contributor

bors-servo commented Oct 22, 2018

📌 Commit 950512d has been approved by ferjm
@bors-servo
Copy link
Contributor

bors-servo commented Oct 22, 2018

😪 I'm awake I'm awake
1 similar comment
@bors-servo
Copy link
Contributor

bors-servo commented Oct 22, 2018

😪 I'm awake I'm awake
@bors-servo
Copy link
Contributor

bors-servo commented Oct 22, 2018

⌛ Testing commit 950512d with merge e0f674d...
bors-servo added a commit that referenced this pull request Oct 22, 2018
@bors-servo
Auto merge of #21999 - asajeffrey:script-dummy-media-position-changed…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e0f674d 
…, r=ferjm

Update servo-media

<!-- Please describe your changes on the following line: -->

Get servo to compile against servo-media master.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because updating a dependency

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21999)
<!-- Reviewable:end -->
@jdm
Copy link
Member

jdm commented Oct 22, 2018

test-tidy failed, and:

  ▶ Unexpected subtest result in /html/semantics/embedded-content/media-elements/readyState_during_loadeddata.html:
  │ FAIL [expected PASS] video.readyState should be >= HAVE_CURRENT_DATA during loadeddata event
  └   → assert_unreached: Reached unreachable code

  ▶ OK [expected TIMEOUT] /html/semantics/embedded-content/media-elements/event_timeupdate_noautoplay.html

  ▶ Unexpected subtest result in /html/semantics/embedded-content/media-elements/event_timeupdate_noautoplay.html:
  │ FAIL [expected NOTRUN] calling play() on a sufficiently long audio should trigger timeupdate event
  └   → assert_unreached: Reached unreachable code

  ▶ Unexpected subtest result in /html/semantics/embedded-content/media-elements/event_timeupdate_noautoplay.html:
  │ FAIL [expected NOTRUN] calling play() on a sufficiently long video should trigger timeupdate event
  └   → assert_unreached: Reached unreachable code
@asajeffrey
Copy link
Member Author

asajeffrey commented Oct 22, 2018

Grr, did I not check in the replace-tabs-by-spaces edit?
@asajeffrey
Copy link
Member Author

asajeffrey commented Oct 23, 2018

Very weird, the copy at my end has no TABs. GH weirdness?
@asajeffrey
Updated servo-media
Loading status checks…
4282141
@asajeffrey asajeffrey force-pushed the asajeffrey:script-dummy-media-position-changed branch from 950512d to 4282141 Oct 23, 2018
@asajeffrey
Copy link
Member Author

asajeffrey commented Oct 23, 2018

Updated test expectations. @bors-servo r=ferjm
@bors-servo
Copy link
Contributor

bors-servo commented Oct 23, 2018

📌 Commit 4282141 has been approved by ferjm
@bors-servo
Copy link
Contributor

bors-servo commented Oct 23, 2018

⌛ Testing commit 4282141 with merge 9be304f...
bors-servo added a commit that referenced this pull request Oct 23, 2018
@bors-servo
Auto merge of #21999 - asajeffrey:script-dummy-media-position-changed…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9be304f 
…, r=ferjm

Update servo-media

<!-- Please describe your changes on the following line: -->

Get servo to compile against servo-media master.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because updating a dependency

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21999)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 23, 2018

💔 Test failed - linux-rel-css
This was referenced Oct 23, 2018
Open
Closed
@jdm
Copy link
Member

jdm commented Oct 23, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Oct 23, 2018

⌛ Testing commit 4282141 with merge 534052b...
bors-servo added a commit that referenced this pull request Oct 23, 2018
@bors-servo
Auto merge of #21999 - asajeffrey:script-dummy-media-position-changed…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
534052b 
…, r=ferjm

Update servo-media

<!-- Please describe your changes on the following line: -->

Get servo to compile against servo-media master.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because updating a dependency

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21999)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 23, 2018

💔 Test failed - linux-rel-css
@jdm
Copy link
Member

jdm commented Oct 23, 2018 •
edited

@bors-servo retry #22008
1 similar comment
@jrmuizel
Copy link

jrmuizel commented Oct 23, 2018

@bors-servo retry #22008
@bors-servo
Copy link
Contributor

bors-servo commented Oct 23, 2018

@jrmuizel: 🔑 Insufficient privileges: not in try users
@bors-servo
Copy link
Contributor

bors-servo commented Oct 23, 2018

⌛ Testing commit 4282141 with merge b19f9d9...
bors-servo added a commit that referenced this pull request Oct 23, 2018
@bors-servo
Auto merge of #21999 - asajeffrey:script-dummy-media-position-changed…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b19f9d9 
…, r=ferjm

Update servo-media

<!-- Please describe your changes on the following line: -->

Get servo to compile against servo-media master.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because updating a dependency

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21999)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 23, 2018

💔 Test failed - linux-rel-css
@asajeffrey
Copy link
Member Author

asajeffrey commented Oct 23, 2018

@bors-servo retry #22010
@bors-servo
Copy link
Contributor

bors-servo commented Oct 23, 2018

⚡ Previous build results for android, android-mac, android-x86, arm32, arm64, linux-dev, linux-rel-wpt, mac-dev-unit, mac-rel-css2, mac-rel-wpt3, windows-msvc-dev are reusable. Rebuilding only linux-rel-css, mac-rel-css1, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt4...
@bors-servo
Copy link
Contributor

bors-servo commented Oct 23, 2018

☀️ Test successful - android, android-mac, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: ferjm
Pushing b19f9d9 to master...
@bors-servo bors-servo merged commit 4282141 into servo:master Oct 23, 2018
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Oct 23, 2018
Merged
3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ferjm ferjm

Labels
A-content/media S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@asajeffrey @ferjm @jdm @highfive @bors-servo @jrmuizel
You can’t perform that action at this time.