Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic HTMLMediaElement seeking #22005

Merged
merged 8 commits into from Oct 26, 2018
Merged

Basic HTMLMediaElement seeking #22005

merged 8 commits into from Oct 26, 2018
+380 −117

Conversation

@ferjm
Copy link
Member

ferjm commented Oct 23, 2018 •
edited by SimonSapin

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #21998

This allows media seeking only when the server supports byte-range requests.

This change is Reviewable
@highfive
Copy link

highfive commented Oct 23, 2018

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/htmlmediaelement.rs, components/script/dom/webidls/HTMLMediaElement.webidl
  • @KiChjang: components/script/dom/htmlmediaelement.rs, components/script/dom/webidls/HTMLMediaElement.webidl
@highfive
Copy link

highfive commented Oct 23, 2018

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@Eijebong
Eijebong reviewed Oct 23, 2018
View changes
Cargo.lock Outdated
@@ -2820,7 +2820,7 @@ dependencies = [
"lazy_static 1.0.0 (registry+https://github.com/rust-lang/crates.io-index)",
"libc 0.2.42 (registry+https://github.com/rust-lang/crates.io-index)",
"num_cpus 1.4.0 (registry+https://github.com/rust-lang/crates.io-index)",
"rand 0.4.2 (registry+https://github.com/rust-lang/crates.io-index)",
"rand 0.3.22 (registry+https://github.com/rust-lang/crates.io-index)",

This comment has been minimized.

Sign in to view
@Eijebong

Eijebong Oct 23, 2018

Member

Uh ?

This comment has been minimized.

Sign in to view
@ferjm

ferjm Oct 23, 2018

Author Member

Hmm... no idea why this happened. I run ./mach cargo-update -p servo-media as usual.
@ferjm
Copy link
Member Author

ferjm commented Oct 23, 2018 •
edited

demo
@ferjm
Copy link
Member Author

ferjm commented Oct 23, 2018

@bors-servo try=wpt
@bors-servo
Copy link
Contributor

bors-servo commented Oct 23, 2018

⌛ Trying commit a1a92ad with merge 3a7b7e8...
bors-servo added a commit that referenced this pull request Oct 23, 2018
@bors-servo
Auto merge of #22005 - ferjm:media.timeline, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3a7b7e8 
Basic HTMLMediaElement seeking

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #21998

This allows media seeking only when the server supports byte-range requests.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22005)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 23, 2018

☔ The latest upstream changes (presumably #21999) made this pull request unmergeable. Please resolve the merge conflicts.
@bors-servo
Copy link
Contributor

bors-servo commented Oct 23, 2018

💔 Test failed - linux-rel-css
@ferjm ferjm force-pushed the ferjm:media.timeline branch from a1a92ad to be0d5d1 Oct 24, 2018
@ferjm ferjm force-pushed the ferjm:media.timeline branch from be0d5d1 to 49611d1 Oct 24, 2018
@ferjm ferjm removed the S-needs-rebase label Oct 24, 2018
@ferjm ferjm force-pushed the ferjm:media.timeline branch from 49611d1 to 8da553f Oct 24, 2018
@ferjm
Copy link
Member Author

ferjm commented Oct 24, 2018

@bors-servo try=wpt
@bors-servo
Copy link
Contributor

bors-servo commented Oct 24, 2018

⌛ Trying commit 8da553f with merge 9ce8a3d...
bors-servo added a commit that referenced this pull request Oct 24, 2018
@bors-servo
Auto merge of #22005 - ferjm:media.timeline, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9ce8a3d 
Basic HTMLMediaElement seeking

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #21998

This allows media seeking only when the server supports byte-range requests.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22005)
<!-- Reviewable:end -->
@ferjm
Copy link
Member Author

ferjm commented Oct 24, 2018

r? @ceyusa
@bors-servo
Copy link
Contributor

bors-servo commented Oct 24, 2018

💔 Test failed - linux-rel-css
@ferjm ferjm force-pushed the ferjm:media.timeline branch from 8da553f to 49389a7 Oct 24, 2018
@ferjm
Copy link
Member Author

ferjm commented Oct 24, 2018

The remaining WPTs failures are because we don't expose the seekable property yet.

@bors-servo try=wpt
bors-servo added a commit that referenced this pull request Oct 24, 2018
@bors-servo
Auto merge of #22005 - ferjm:media.timeline, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0cf52d8 
Basic HTMLMediaElement seeking

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #21998

This allows media seeking only when the server supports byte-range requests.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22005)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 24, 2018

⌛ Trying commit 49389a7 with merge 0cf52d8...
@bors-servo
Copy link
Contributor

bors-servo commented Oct 24, 2018

💔 Test failed - linux-rel-css
@ferjm
Update interfaces test expectations
Loading status checks…
d7629b7
@ferjm
Copy link
Member Author

ferjm commented Oct 26, 2018

@bors-servo r=ceyusa
@bors-servo
Copy link
Contributor

bors-servo commented Oct 26, 2018

📌 Commit d7629b7 has been approved by ceyusa
@bors-servo
Copy link
Contributor

bors-servo commented Oct 26, 2018

⌛ Testing commit d7629b7 with merge c88f12d...
bors-servo added a commit that referenced this pull request Oct 26, 2018
@bors-servo
Auto merge of #22005 - ferjm:media.timeline, r=ceyusa
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c88f12d 
Basic HTMLMediaElement seeking

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #21998

This allows media seeking only when the server supports byte-range requests.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22005)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 26, 2018

💔 Test failed - linux-rel-wpt
@ferjm
Copy link
Member Author

ferjm commented Oct 26, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Oct 26, 2018

⌛ Testing commit d7629b7 with merge cb915d6...
bors-servo added a commit that referenced this pull request Oct 26, 2018
@bors-servo
Auto merge of #22005 - ferjm:media.timeline, r=ceyusa
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
cb915d6 
Basic HTMLMediaElement seeking

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #21998

This allows media seeking only when the server supports byte-range requests.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22005)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 26, 2018

💔 Test failed - mac-rel-css2
@ferjm
Copy link
Member Author

ferjm commented Oct 26, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Oct 26, 2018

⚡ Previous build results for android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-rel-css1, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, status-taskcluster, windows-msvc-dev are reusable. Rebuilding only android-mac, mac-dev-unit, mac-rel-css2...
@bors-servo
Copy link
Contributor

bors-servo commented Oct 26, 2018

☀️ Test successful - android, android-mac, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, status-taskcluster, windows-msvc-dev
Approved by: ceyusa
Pushing cb915d6 to master...
@bors-servo bors-servo merged commit d7629b7 into servo:master Oct 26, 2018
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
This was referenced Oct 26, 2018
Merged
Merged
@ferjm ferjm deleted the ferjm:media.timeline branch Oct 29, 2018
@ferjm ferjm added this to Done in Media playback Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ceyusa ceyusa

@Eijebong Eijebong

Assignees

@nox nox

Labels
S-tests-failed
Projects
Media playback
  
Done
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Support for HTMLMediaElement seeking and related API properties
6 participants
@ferjm @highfive @bors-servo @ceyusa @Eijebong @nox
You can’t perform that action at this time.