Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle open URL intent on Android #22013

Merged
merged 1 commit into from Oct 25, 2018

Conversation

Projects
None yet
5 participants
@ferjm
Copy link
Member

ferjm commented Oct 24, 2018

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #21997

This makes it easier to use Servo as the default browser.


This change is Reviewable

@ferjm

This comment has been minimized.

Copy link
Member Author

ferjm commented Oct 24, 2018

@highfive highfive assigned paulrouget and unassigned nox Oct 24, 2018

@paulrouget

This comment has been minimized.

Copy link
Contributor

paulrouget commented Oct 24, 2018

Thank you.

@bors-servo r+

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Oct 24, 2018

📌 Commit e3a5568 has been approved by paulrouget

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Oct 24, 2018

⌛️ Testing commit e3a5568 with merge 657173a...

bors-servo added a commit that referenced this pull request Oct 24, 2018

Auto merge of #22013 - ferjm:android.openurl.intent, r=paulrouget
Handle open URL intent on Android

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #21997

This makes it easier to use Servo as the default browser.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22013)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Oct 24, 2018

💔 Test failed - mac-rel-css1

@ferjm

This comment has been minimized.

Copy link
Member Author

ferjm commented Oct 24, 2018

@bors-servo retry

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Oct 24, 2018

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Oct 24, 2018

@bors-servo bors-servo merged commit e3a5568 into servo:master Oct 25, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@ferjm ferjm deleted the ferjm:android.openurl.intent branch Oct 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.