New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: proper shutdown mechanism #22021

Merged
merged 1 commit into from Oct 30, 2018

Conversation

Projects
None yet
5 participants
@paulrouget
Contributor

paulrouget commented Oct 26, 2018

Fix #21834


This change is Reviewable

@paulrouget paulrouget assigned jdm and unassigned nox Oct 29, 2018

@paulrouget

This comment has been minimized.

Contributor

paulrouget commented Oct 29, 2018

@jdm r?

@jdm

jdm approved these changes Oct 29, 2018

@@ -70,6 +70,8 @@ pub fn Java_org_mozilla_servoview_JNIServo_init(
"script::dom::bindings::error",
// Show GL errors by default.
"canvas::webgl_thread",
"compositing::compositor",
"constellation::constellation",

This comment has been minimized.

@jdm

jdm Oct 29, 2018

Member

Do we still want these on by default?

This comment has been minimized.

@paulrouget

paulrouget Oct 30, 2018

Contributor

yes. I keep adding them back for debugging. And it's not too verbose.

@jdm

This comment has been minimized.

Member

jdm commented Oct 29, 2018

@bors-servo delegate+

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 29, 2018

✌️ @paulrouget can now approve this pull request

@paulrouget

This comment has been minimized.

Contributor

paulrouget commented Oct 30, 2018

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 30, 2018

📌 Commit 549c8c5 has been approved by paulrouget

@highfive highfive assigned paulrouget and unassigned jdm Oct 30, 2018

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 30, 2018

⌛️ Testing commit 549c8c5 with merge 662fd0a...

bors-servo added a commit that referenced this pull request Oct 30, 2018

Auto merge of #22021 - paulrouget:shutdown, r=paulrouget
Android: proper shutdown mechanism

Fix #21834

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22021)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 30, 2018

@bors-servo bors-servo merged commit 549c8c5 into servo:master Oct 30, 2018

1 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment