Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAndroid: proper shutdown mechanism #22021
Merged
Conversation
This was referenced Oct 26, 2018
|
@jdm r? |
| @@ -70,6 +70,8 @@ pub fn Java_org_mozilla_servoview_JNIServo_init( | |||
| "script::dom::bindings::error", | |||
| // Show GL errors by default. | |||
| "canvas::webgl_thread", | |||
| "compositing::compositor", | |||
| "constellation::constellation", | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
paulrouget
Oct 30, 2018
•
Author
Contributor
yes. I keep adding them back for debugging. And it's not too verbose.
|
@bors-servo delegate+ |
|
|
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 30, 2018
Android: proper shutdown mechanism Fix #21834 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22021) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
paulrouget commentedOct 26, 2018
•
edited by SimonSapin
Fix #21834
This change is