Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ChildNode.remove() #2205

Closed
wants to merge 1 commit into from
Closed

Implement ChildNode.remove() #2205

wants to merge 1 commit into from

Conversation

@hmac
Copy link
Contributor

hmac commented Apr 22, 2014

Fixes #2191

@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Apr 22, 2014

Critic review: https://critic.hoppipolla.co.uk/r/1346

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@highfive
Copy link

highfive commented Apr 22, 2014

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @kmcallister (or someone else) soon.

@Ms2ger
Copy link
Contributor

Ms2ger commented Apr 22, 2014

Commented on critic; please leave your email address there.

@jdm
Copy link
Member

jdm commented May 2, 2014

Waiting on further review by @Ms2ger.

@Ms2ger
Copy link
Contributor

Ms2ger commented May 2, 2014

@Ms2ger
Copy link
Contributor

Ms2ger commented May 5, 2014

@Hazz, could you rebase again? I'll try to make sure it's the last time :)

@jdm
Copy link
Member

jdm commented May 5, 2014

I'm rebasing this; don't worry about it.

@jdm
Copy link
Member

jdm commented May 5, 2014

Rebased in #2326.

@jdm jdm closed this May 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can’t perform that action at this time.