Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement ChildNode.remove() #2205
Conversation
hoppipolla-critic-bot
commented
Apr 22, 2014
|
Critic review: https://critic.hoppipolla.co.uk/r/1346 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
highfive
commented
Apr 22, 2014
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @kmcallister (or someone else) soon. |
|
Commented on critic; please leave your email address there. |
|
Waiting on further review by @Ms2ger. |
|
@Hazz, please rebase as explained at https://github.com/mozilla/servo/wiki/Github-%26-Critic-PR-handling-101 |
|
@Hazz, could you rebase again? I'll try to make sure it's the last time :) |
|
I'm rebasing this; don't worry about it. |
|
Rebased in #2326. |
hmac commentedApr 22, 2014
Fixes #2191