Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTMLMediaElement - fire durationchange and resize iff something changes #22052

Merged
merged 1 commit into from Oct 30, 2018
Merged

HTMLMediaElement - fire durationchange and resize iff something changes #22052

merged 1 commit into from Oct 30, 2018

Conversation

@ferjm
Copy link
Member

ferjm commented Oct 30, 2018 •
edited by SimonSapin

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors

This change is Reviewable
@ferjm
HTMLMediaElement - fire durationchange and resize iff something changes
Loading status checks…
35508c1
@highfive
Copy link

highfive commented Oct 30, 2018

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/htmlvideoelement.rs, components/script/dom/htmlmediaelement.rs
  • @KiChjang: components/script/dom/htmlvideoelement.rs, components/script/dom/htmlmediaelement.rs
@highfive
Copy link

highfive commented Oct 30, 2018

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@ferjm
Copy link
Member Author

ferjm commented Oct 30, 2018

@bors-servo try=wpt
@bors-servo
Copy link
Contributor

bors-servo commented Oct 30, 2018

⌛ Trying commit 35508c1 with merge 357c548...
bors-servo added a commit that referenced this pull request Oct 30, 2018
@bors-servo
Auto merge of #22052 - ferjm:durationchange.resize.event.once, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
357c548 
HTMLMediaElement - fire durationchange and resize iff something changes

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22052)
<!-- Reviewable:end -->
@ferjm
Copy link
Member Author

ferjm commented Oct 30, 2018

r? @ceyusa
@ceyusa
Copy link
Collaborator

ceyusa commented Oct 30, 2018

r+

thanks!
@bors-servo
Copy link
Contributor

bors-servo commented Oct 30, 2018

☀️ Test successful - linux-rel-css, linux-rel-wpt
State: approved= try=True
@ferjm
Copy link
Member Author

ferjm commented Oct 30, 2018

@bors-servo r=ceyusa
@bors-servo
Copy link
Contributor

bors-servo commented Oct 30, 2018

📌 Commit 35508c1 has been approved by ceyusa
@bors-servo
Copy link
Contributor

bors-servo commented Oct 30, 2018

⌛ Testing commit 35508c1 with merge 7a71551...
bors-servo added a commit that referenced this pull request Oct 30, 2018
@bors-servo
Auto merge of #22052 - ferjm:durationchange.resize.event.once, r=ceyusa
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7a71551 
HTMLMediaElement - fire durationchange and resize iff something changes

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22052)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 30, 2018

☀️ Test successful - android, android-mac, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, status-taskcluster, windows-msvc-dev
Approved by: ceyusa
Pushing 7a71551 to master...
@bors-servo bors-servo merged commit 35508c1 into servo:master Oct 30, 2018
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@ferjm ferjm added this to In progress in Media playback Nov 29, 2018
@ferjm ferjm moved this from In progress to Done in Media playback Nov 29, 2018
@ferjm ferjm deleted the ferjm:durationchange.resize.event.once branch Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
None yet
Projects
Media playback
  
Done
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@ferjm @highfive @bors-servo @ceyusa @Manishearth
You can’t perform that action at this time.