Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a build switch to disable the native bluetooth backend. #22060

Merged
merged 1 commit into from Nov 1, 2018
Merged

Add a build switch to disable the native bluetooth backend. #22060

merged 1 commit into from Nov 1, 2018

Conversation

@jdm
Copy link
Member

jdm commented Oct 31, 2018 •
edited by SimonSapin

Fixes #22059.

This change is Reviewable
@jdm
Add a build switch to disable the native bluetooth backend.
Loading status checks…
83fda75
@highfive
Copy link

highfive commented Oct 31, 2018

Heads up! This PR modifies the following files:
@jdm
Copy link
Member Author

jdm commented Oct 31, 2018

r? @asajeffrey
@highfive highfive assigned asajeffrey and unassigned nox Oct 31, 2018
@asajeffrey
asajeffrey approved these changes Oct 31, 2018
View changes
@asajeffrey
Copy link
Member

asajeffrey commented Oct 31, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Oct 31, 2018

📌 Commit 83fda75 has been approved by asajeffrey
@bors-servo
Copy link
Contributor

bors-servo commented Oct 31, 2018

⌛ Testing commit 83fda75 with merge 61cc450...
bors-servo added a commit that referenced this pull request Oct 31, 2018
@bors-servo
Auto merge of #22060 - jdm:ml, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
61cc450 
Add a build switch to disable the native bluetooth backend.

Fixes #22059.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22060)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 31, 2018

💔 Test failed - linux-rel-wpt
@jdm
Copy link
Member Author

jdm commented Oct 31, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Oct 31, 2018

⚡ Previous build results for android, android-mac, android-x86, arm32, arm64, linux-dev, linux-rel-css, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, status-taskcluster are reusable. Rebuilding only linux-rel-wpt, windows-msvc-dev...
@bors-servo
Copy link
Contributor

bors-servo commented Oct 31, 2018

💔 Test failed - linux-rel-wpt
@jdm
Copy link
Member Author

jdm commented Oct 31, 2018

@bors-servo retry

  • oom
bors-servo added a commit that referenced this pull request Oct 31, 2018
@bors-servo
Auto merge of #22060 - jdm:ml, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
925aa4f 
Add a build switch to disable the native bluetooth backend.

Fixes #22059.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22060)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 31, 2018

⌛ Testing commit 83fda75 with merge 925aa4f...
@bors-servo
Copy link
Contributor

bors-servo commented Oct 31, 2018

💔 Test failed - status-taskcluster
@jdm
Copy link
Member Author

jdm commented Oct 31, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Oct 31, 2018

⌛ Testing commit 83fda75 with merge aeee720...
bors-servo added a commit that referenced this pull request Oct 31, 2018
@bors-servo
Auto merge of #22060 - jdm:ml, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
aeee720 
Add a build switch to disable the native bluetooth backend.

Fixes #22059.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22060)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 31, 2018

💔 Test failed - status-taskcluster
@CYBAI
Copy link
Collaborator

CYBAI commented Nov 1, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Nov 1, 2018

⌛ Testing commit 83fda75 with merge 8799521...
bors-servo added a commit that referenced this pull request Nov 1, 2018
@bors-servo
Auto merge of #22060 - jdm:ml, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8799521 
Add a build switch to disable the native bluetooth backend.

Fixes #22059.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22060)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 1, 2018

💔 Test failed - linux-rel-wpt
@CYBAI
Copy link
Collaborator

CYBAI commented Nov 1, 2018

@bors-servo retry

{"status": "TIMEOUT", "group": "default", "message": null, "stack": null, "subtest": null, "test": "/_webgl/conformance/attribs/gl-vertex-attrib-zero-issues.html", "line": 204289, "action": "test_result", "expected": "OK"}
{"status": "TIMEOUT", "group": "default", "message": null, "stack": null, "subtest": null, "test": "/_webgl/conformance/attribs/gl-vertex-attrib.html", "line": 204297, "action": "test_result", "expected": "OK"}
@bors-servo
Copy link
Contributor

bors-servo commented Nov 1, 2018

⌛ Testing commit 83fda75 with merge 126ed26...
bors-servo added a commit that referenced this pull request Nov 1, 2018
@bors-servo
Auto merge of #22060 - jdm:ml, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
126ed26 
Add a build switch to disable the native bluetooth backend.

Fixes #22059.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22060)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 1, 2018

☀️ Test successful - android, android-mac, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, status-taskcluster, windows-msvc-dev
Approved by: asajeffrey
Pushing 126ed26 to master...
@bors-servo bors-servo merged commit 83fda75 into servo:master Nov 1, 2018
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asajeffrey asajeffrey

Assignees

@asajeffrey asajeffrey

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@jdm @highfive @asajeffrey @bors-servo @CYBAI @nox
You can’t perform that action at this time.