Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update webrender. #22074

Merged
merged 1 commit into from Nov 7, 2018
Merged

Update webrender. #22074

merged 1 commit into from Nov 7, 2018

Conversation

@jdm
Copy link
Member

jdm commented Nov 1, 2018 •
edited

Fixes #22114.

This change is Reviewable
@highfive
Copy link

highfive commented Nov 1, 2018

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/Cargo.toml, components/webdriver_server/Cargo.toml
  • @jgraham: components/webdriver_server/Cargo.toml
  • @edunham: servo-tidy.toml
  • @KiChjang: components/net/Cargo.toml, components/script/Cargo.toml
  • @emilio: components/layout/display_list/webrender_helpers.rs
@highfive
Copy link

highfive commented Nov 1, 2018

warning Warning warning

  • These commits modify net, layout, gfx, and script code, but no tests are modified. Please consider adding a test!
@jdm
Copy link
Member Author

jdm commented Nov 1, 2018

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Nov 1, 2018

⌛ Trying commit 647643f with merge e78715c...
bors-servo added a commit that referenced this pull request Nov 1, 2018
@bors-servo
Auto merge of #22074 - jdm:wrup, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e78715c 
Update webrender.

I tried updating to see if it would help #22073 but it didn't. Might as well merge it, though!

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22074)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 1, 2018

💔 Test failed - status-taskcluster
@jdm jdm force-pushed the jdm:wrup branch from 647643f to 5fb24f1 Nov 1, 2018
@highfive highfive removed the S-tests-failed label Nov 1, 2018
@jdm
Copy link
Member Author

jdm commented Nov 1, 2018

@bors-servo try=wpt
@bors-servo
Copy link
Contributor

bors-servo commented Nov 1, 2018

⌛ Trying commit 5fb24f1 with merge b17e4de...
bors-servo added a commit that referenced this pull request Nov 1, 2018
@bors-servo
Auto merge of #22074 - jdm:wrup, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b17e4de 
Update webrender.

I tried updating to see if it would help #22073 but it didn't. Might as well merge it, though!

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22074)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 1, 2018

💔 Test failed - linux-rel-wpt
@jdm
Copy link
Member Author

jdm commented Nov 1, 2018 

{"status": "FAIL", "group": "default", "message": "/css/css-backgrounds/border-image-width-008.html eed29f90ce10dd757c1bdd1f14ea2b93325b5eb3\n/css/css-backgrounds/border-image-width-008-ref.html 2c92c62d2db2ddc7907c7163c1c07f225a42190a\nTesting eed29f90ce10dd757c1bdd1f14ea2b93325b5eb3 == 2c92c62d2db2ddc7907c7163c1c07f225a42190a", "stack": null, "subtest": null, "test": "/css/css-backgrounds/border-image-width-008.html", "line": 26175, "action": "test_result", "expected": "PASS"}

This is repeatedly failing. I'll take a look at the reftest analyzer when I'm in a position to download the 100mb log file.
@bors-servo
Copy link
Contributor

bors-servo commented Nov 1, 2018

☔ The latest upstream changes (presumably #21644) made this pull request unmergeable. Please resolve the merge conflicts.
@jdm
Copy link
Member Author

jdm commented Nov 1, 2018

screen shot 2018-11-01 at 5 00 17 pm
@jdm jdm force-pushed the jdm:wrup branch from 5fb24f1 to d9cbf1b Nov 6, 2018
@highfive highfive removed the S-tests-failed label Nov 6, 2018
@jdm
Copy link
Member Author

jdm commented Nov 6, 2018

This makes images appear on android for me.
@jdm jdm removed the S-needs-rebase label Nov 6, 2018
@jdm jdm force-pushed the jdm:wrup branch from d9cbf1b to 9d6fd7a Nov 6, 2018
@jdm
Copy link
Member Author

jdm commented Nov 6, 2018

@bors-servo r=nox
@bors-servo
Copy link
Contributor

bors-servo commented Nov 6, 2018

📌 Commit 9d6fd7a has been approved by nox
@highfive highfive assigned nox and unassigned emilio Nov 6, 2018
bors-servo added a commit that referenced this pull request Nov 6, 2018
@bors-servo
Auto merge of #22074 - jdm:wrup, r=nox
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
cfe63fb 
Update webrender.

Fixes #22114.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22074)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 6, 2018

💔 Test failed - status-taskcluster
@jdm
Copy link
Member Author

jdm commented Nov 7, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Nov 7, 2018

⌛ Testing commit 1c5e4b3 with merge 471398f...
bors-servo added a commit that referenced this pull request Nov 7, 2018
@bors-servo
Auto merge of #22074 - jdm:wrup, r=nox
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
471398f 
Update webrender.

Fixes #22114.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22074)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 7, 2018

💔 Test failed - android-x86
@jdm
Copy link
Member Author

jdm commented Nov 7, 2018

@bors-servo retry

  • network
@bors-servo
Copy link
Contributor

bors-servo commented Nov 7, 2018

⌛ Testing commit 1c5e4b3 with merge 77d2ec3...
bors-servo added a commit that referenced this pull request Nov 7, 2018
@bors-servo
Auto merge of #22074 - jdm:wrup, r=nox
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
77d2ec3 
Update webrender.

Fixes #22114.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22074)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 7, 2018

💔 Test failed - status-taskcluster
@CYBAI
Copy link
Collaborator

CYBAI commented Nov 7, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Nov 7, 2018

💣 Failed to start rebuilding: Unknown error
@bors-servo
Copy link
Contributor

bors-servo commented Nov 7, 2018

⌛ Testing commit 1c5e4b3 with merge 618a790...
bors-servo added a commit that referenced this pull request Nov 7, 2018
@bors-servo
Auto merge of #22074 - jdm:wrup, r=nox
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
618a790 
Update webrender.

Fixes #22114.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22074)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 7, 2018

☀️ Test successful - android, android-mac, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, status-taskcluster, windows-msvc-dev
Approved by: nox
Pushing 618a790 to master...
@bors-servo bors-servo merged commit 1c5e4b3 into servo:master Nov 7, 2018
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Nov 7, 2018
Merged
0 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@jdm @highfive @bors-servo @CYBAI @nox @emilio
You can’t perform that action at this time.