Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update syn #22085

Merged
merged 1 commit into from Nov 30, 2018
Merged

Update syn #22085

merged 1 commit into from Nov 30, 2018

Conversation

@Eijebong
Copy link
Member

Eijebong commented Nov 1, 2018 •
edited by SimonSapin

This change is Reviewable
@highfive
Copy link

highfive commented Nov 1, 2018

Heads up! This PR modifies the following files:

  • @edunham: servo-tidy.toml
  • @emilio: components/layout/display_list/webrender_helpers.rs
@highfive
Copy link

highfive commented Nov 1, 2018

warning Warning warning

  • These commits modify gfx and layout code, but no tests are modified. Please consider adding a test!
@Eijebong Eijebong force-pushed the Eijebong:synup branch from f13ea13 to d800a70 Nov 3, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Nov 5, 2018

☔ The latest upstream changes (presumably #22111) made this pull request unmergeable. Please resolve the merge conflicts.
@Eijebong
Update syn and related dependencies
Loading status checks…
e94de4e
@Eijebong Eijebong force-pushed the Eijebong:synup branch from d800a70 to e94de4e Nov 30, 2018
@Eijebong Eijebong changed the title WIP: Update syn Update syn Nov 30, 2018
@Eijebong
Copy link
Member Author

Eijebong commented Nov 30, 2018

This should be good to go now
@jdm
Copy link
Member

jdm commented Nov 30, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Nov 30, 2018

📌 Commit e94de4e has been approved by jdm
@highfive highfive assigned jdm and unassigned ferjm Nov 30, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Nov 30, 2018

⌛ Testing commit e94de4e with merge 097c85e...
bors-servo added a commit that referenced this pull request Nov 30, 2018
@bors-servo
Auto merge of #22085 - Eijebong:synup, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
097c85e 
Update syn

- servo/html5ever#353
- servo/rust-cssparser#229
- servo/webrender#3264
- servo/media#162
- rust-lang/rust-bindgen#1409

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22085)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 30, 2018

☀️ Test successful - android, android-mac, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster, windows-msvc-dev
Approved by: jdm
Pushing 097c85e to master...
@bors-servo bors-servo merged commit e94de4e into servo:master Nov 30, 2018
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@atouchet atouchet mentioned this pull request Jan 6, 2019
Closed
4 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@Eijebong @highfive @bors-servo @jdm @ferjm
You can’t perform that action at this time.