Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch some crates to the 2018 edition #22086

Merged
merged 8 commits into from Nov 6, 2018
Merged

Switch some crates to the 2018 edition #22086

merged 8 commits into from Nov 6, 2018
+5,306 −5,238

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Nov 1, 2018 •
edited

This is the subset of #22083 that doesn’t affect Gecko at all, so it isn’t blocked.

This change is Reviewable
@KiChjang
KiChjang reviewed Nov 1, 2018
View changes
components/canvas_traits/webgl.rs Outdated Show resolved Hide resolved
@SimonSapin SimonSapin force-pushed the 2018-without-stylo branch 2 times, most recently from e1ce02e to 768a18b Nov 5, 2018
@jdm
Copy link
Member

jdm commented Nov 5, 2018

The windows build is unhappy.
@SimonSapin SimonSapin force-pushed the 2018-without-stylo branch 3 times, most recently from ca964a8 to f5bc7fc Nov 5, 2018
@SimonSapin
Copy link
Member Author

SimonSapin commented Nov 5, 2018

Fixed up macOS and Windows.

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Nov 5, 2018

⌛ Trying commit f5bc7fc with merge 98ffa2a...
bors-servo added a commit that referenced this pull request Nov 5, 2018
@bors-servo
Auto merge of #22086 - servo:2018-without-stylo, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
98ffa2a 
Switch some crates to the 2018 edition

This is the subset of #22083 that doesn’t affect Gecko at all, so it isn’t blocked.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22086)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 5, 2018

💔 Test failed - status-taskcluster
@SimonSapin
Copy link
Member Author

SimonSapin commented Nov 5, 2018

@bors-servo try
@SimonSapin SimonSapin force-pushed the 2018-without-stylo branch from f5bc7fc to 65ae79b Nov 5, 2018
@highfive highfive removed the S-tests-failed label Nov 5, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Nov 5, 2018

⌛ Testing commit 65ae79b with merge 9de0fce...
bors-servo added a commit that referenced this pull request Nov 5, 2018
@bors-servo
Auto merge of #22086 - servo:2018-without-stylo, r=
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9de0fce 
Switch some crates to the 2018 edition

This is the subset of #22083 that doesn’t affect Gecko at all, so it isn’t blocked.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22086)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 5, 2018

💔 Test failed - linux-dev
@bors-servo
Copy link
Contributor

bors-servo commented Nov 5, 2018

☔ The latest upstream changes (presumably #22099) made this pull request unmergeable. Please resolve the merge conflicts.
@SimonSapin SimonSapin force-pushed the 2018-without-stylo branch from 65ae79b to 320a5bf Nov 6, 2018
@SimonSapin
Copy link
Member Author

SimonSapin commented Nov 6, 2018

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Nov 6, 2018

⌛ Trying commit 320a5bf with merge 2508552...
@bors-servo
Copy link
Contributor

bors-servo commented Nov 6, 2018

💔 Test failed - status-taskcluster
@SimonSapin
Copy link
Member Author

SimonSapin commented Nov 6, 2018

I believe this Android x86 emulator test failure is intermittent, clicking "Actions" then "Retrigger Task" produced a green task: https://tools.taskcluster.net/groups/VUgXtYAwTPKWbpjaDZ72BA/tasks/I2Lh3hmtQq-7alaHFQPP9A/details
@SimonSapin
Copy link
Member Author

SimonSapin commented Nov 6, 2018

This is almost entirely mechanical, let’s rubber stamp.

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Nov 6, 2018

📌 Commit 8757cf5 has been approved by SimonSapin
bors-servo added a commit that referenced this pull request Nov 6, 2018
@bors-servo
Auto merge of #22086 - servo:2018-without-stylo, r=SimonSapin
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6878dbb 
Switch some crates to the 2018 edition

This is the subset of #22083 that doesn’t affect Gecko at all, so it isn’t blocked.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22086)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 6, 2018

⌛ Testing commit 8757cf5 with merge 6878dbb...
@bors-servo
Copy link
Contributor

bors-servo commented Nov 6, 2018

💔 Test failed - mac-rel-wpt1
@SimonSapin
Copy link
Member Author

SimonSapin commented Nov 6, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Nov 6, 2018

⚡ Previous build results for android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, status-taskcluster, windows-msvc-dev are reusable. Rebuilding only android-mac, mac-rel-wpt1...
@bors-servo
Copy link
Contributor

bors-servo commented Nov 6, 2018

☀️ Test successful - android, android-mac, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, status-taskcluster, windows-msvc-dev
Approved by: SimonSapin
Pushing 6878dbb to master...
@bors-servo bors-servo merged commit 8757cf5 into master Nov 6, 2018
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
This was referenced Nov 6, 2018
Merged
Merged
Closed
Closed
Merged
Merged
Open
Closed
@SimonSapin SimonSapin deleted the 2018-without-stylo branch Nov 6, 2018
@SimonSapin SimonSapin mentioned this pull request Nov 7, 2018
Closed
@jdm jdm mentioned this pull request Nov 16, 2018
Merged
0 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KiChjang KiChjang

Assignees

@SimonSapin SimonSapin

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@SimonSapin @jdm @bors-servo @KiChjang @highfive
You can’t perform that action at this time.