Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTMLMediaElement played attribute #22093

Merged
merged 1 commit into from Nov 21, 2018
Merged

HTMLMediaElement played attribute #22093

merged 1 commit into from Nov 21, 2018
+27 −19

Conversation

@ferjm
Copy link
Member

ferjm commented Nov 2, 2018 •
edited by SimonSapin

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors

This change is Reviewable
@highfive
Copy link

highfive commented Nov 2, 2018

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/webidls/HTMLMediaElement.webidl, components/script/dom/htmlmediaelement.rs, components/script/dom/bindings/trace.rs, components/script/dom/timeranges.rs
  • @KiChjang: components/script/dom/webidls/HTMLMediaElement.webidl, components/script/dom/htmlmediaelement.rs, components/script/dom/bindings/trace.rs, components/script/dom/timeranges.rs
@highfive
Copy link

highfive commented Nov 2, 2018

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@ferjm
Copy link
Member Author

ferjm commented Nov 2, 2018

@bors-servo try=wpt
bors-servo added a commit that referenced this pull request Nov 2, 2018
@bors-servo
Auto merge of #22093 - ferjm:media.playing, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5a0296b 
HTMLMediaElement played attribute

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22093)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 2, 2018

⌛ Trying commit 4e70965 with merge 5a0296b...
@ferjm
Copy link
Member Author

ferjm commented Nov 2, 2018

r? @Manishearth
@highfive highfive assigned Manishearth and unassigned nox Nov 2, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Nov 2, 2018

💔 Test failed - linux-rel-wpt
@ferjm ferjm force-pushed the ferjm:media.playing branch from 4e70965 to a98f6af Nov 2, 2018
@highfive highfive removed the S-tests-failed label Nov 2, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Nov 6, 2018

☔ The latest upstream changes (presumably #22086) made this pull request unmergeable. Please resolve the merge conflicts.
@ferjm ferjm force-pushed the ferjm:media.playing branch from a98f6af to 2e3954b Nov 7, 2018
@ferjm ferjm removed the S-needs-rebase label Nov 8, 2018
@ferjm ferjm force-pushed the ferjm:media.playing branch from 2e3954b to eb25277 Nov 8, 2018
@Manishearth
Manishearth requested changes Nov 13, 2018
View changes
components/script/dom/htmlmediaelement.rs Outdated
.played
.borrow_mut()
.add(self.playback_position.get(), position);
println!("PLAYED {:?}", *self.played.borrow());

This comment has been minimized.

Sign in to view
@Manishearth

Manishearth Nov 13, 2018

Member

remove or replace with debug!
components/script/dom/bindings/trace.rs Outdated
@@ -143,6 +144,7 @@ unsafe_no_jsmanaged_fields!(&'static Encoding);

unsafe_no_jsmanaged_fields!(RefCell<Decoder>);
unsafe_no_jsmanaged_fields!(RefCell<Vec<u8>>);
unsafe_no_jsmanaged_fields!(RefCell<TimeRangesContainer>);

This comment has been minimized.

Sign in to view
@Manishearth

Manishearth Nov 13, 2018

Member

This isn't true; TimeRangesContainer is contains JS objects

This comment has been minimized.

Sign in to view
@Manishearth

Manishearth Nov 13, 2018

Member

You probably want to use RootableVec

This comment has been minimized.

Sign in to view
@ferjm

ferjm Nov 13, 2018

Author Member

@Manishearth Sorry, I am not sure how RootableVec would help here. TimeRangesContainer contains TimeRange objects, which IIUC are no JS objects (although they are contained by JS objects). The way I understand it TimeRanges (note the s) is the JS object here.

This comment has been minimized.

Sign in to view
@Manishearth

Manishearth Nov 13, 2018

Member

oh I see.

This comment has been minimized.

Sign in to view
@jdm

jdm Nov 13, 2018

Member

I think this line is unnecessary if you use DomRefCell instead of RefCell.

This comment has been minimized.

Sign in to view
@ferjm

ferjm Nov 14, 2018

Author Member

That's correct. I just updated the code. Thanks.
@ferjm ferjm force-pushed the ferjm:media.playing branch 2 times, most recently from d898f24 to 709391b Nov 13, 2018
@ferjm ferjm force-pushed the ferjm:media.playing branch from 709391b to 9c3fb9f Nov 20, 2018
@ferjm
Copy link
Member Author

ferjm commented Nov 21, 2018

@bors-servo r=Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Nov 21, 2018

📌 Commit 9c3fb9f has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Nov 21, 2018

⌛ Testing commit 9c3fb9f with merge 923ee15...
bors-servo added a commit that referenced this pull request Nov 21, 2018
@bors-servo
Auto merge of #22093 - ferjm:media.playing, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
923ee15 
HTMLMediaElement played attribute

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22093)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 21, 2018

💔 Test failed - linux-rel-wpt
@ferjm
HTMLMediaElement playing attribute
Loading status checks…
f98da2e
@ferjm ferjm force-pushed the ferjm:media.playing branch from 9c3fb9f to f98da2e Nov 21, 2018
@ferjm
Copy link
Member Author

ferjm commented Nov 21, 2018

@bors-servo r=Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Nov 21, 2018

📌 Commit f98da2e has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Nov 21, 2018

⌛ Testing commit f98da2e with merge 45a1ca2...
bors-servo added a commit that referenced this pull request Nov 21, 2018
@bors-servo
Auto merge of #22093 - ferjm:media.playing, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
45a1ca2 
HTMLMediaElement played attribute

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22093)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 21, 2018

☀️ Test successful - android, android-mac, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster, windows-msvc-dev
Approved by: Manishearth
Pushing 45a1ca2 to master...
@bors-servo bors-servo merged commit f98da2e into servo:master Nov 21, 2018
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@ferjm ferjm deleted the ferjm:media.playing branch Nov 21, 2018
@ferjm ferjm added this to Done in Media playback Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdm jdm

@Manishearth Manishearth

Assignees

@Manishearth Manishearth

Labels
None yet
Projects
Media playback
  
Done
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@ferjm @highfive @bors-servo @jdm @Manishearth @nox
You can’t perform that action at this time.