New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon for launching Magic Leap Servo #22095

Merged
merged 1 commit into from Nov 9, 2018

Conversation

Projects
None yet
5 participants
@asajeffrey
Member

asajeffrey commented Nov 2, 2018

Add an icon for launching Magic Leap Servo.


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes do not require tests because we don't test ML

This change is Reviewable

@asajeffrey asajeffrey referenced this pull request Nov 2, 2018

Closed

Package Magic Leap app #22079

2 of 2 tasks complete
@jdm

This comment has been minimized.

Member

jdm commented Nov 8, 2018

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 8, 2018

📌 Commit 0b05df7 has been approved by jdm

@highfive highfive assigned jdm and unassigned ferjm Nov 8, 2018

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 9, 2018

⌛️ Testing commit 0b05df7 with merge b5f0ef1...

bors-servo added a commit that referenced this pull request Nov 9, 2018

Auto merge of #22095 - asajeffrey:magicleap-icon, r=jdm
Add icon for launching Magic Leap Servo

<!-- Please describe your changes on the following line: -->

Add an icon for launching Magic Leap Servo.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because we don't test ML

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22095)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 9, 2018

💔 Test failed - status-taskcluster

@asajeffrey

This comment has been minimized.

Member

asajeffrey commented Nov 9, 2018

@bors-servo retry

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 9, 2018

⌛️ Testing commit 0b05df7 with merge a767e80...

bors-servo added a commit that referenced this pull request Nov 9, 2018

Auto merge of #22095 - asajeffrey:magicleap-icon, r=jdm
Add icon for launching Magic Leap Servo

<!-- Please describe your changes on the following line: -->

Add an icon for launching Magic Leap Servo.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because we don't test ML

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22095)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 9, 2018

💔 Test failed - linux-rel-wpt

@jdm

This comment has been minimized.

Member

jdm commented Nov 9, 2018

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 9, 2018

⌛️ Testing commit 0b05df7 with merge c0aa4ad...

bors-servo added a commit that referenced this pull request Nov 9, 2018

Auto merge of #22095 - asajeffrey:magicleap-icon, r=jdm
Add icon for launching Magic Leap Servo

<!-- Please describe your changes on the following line: -->

Add an icon for launching Magic Leap Servo.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because we don't test ML

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22095)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

@bors-servo bors-servo merged commit 0b05df7 into servo:master Nov 9, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment