Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upstyle: Sync changes from mozilla-central. #22111
Merged
Conversation
Also remove specified-value-only keywords, since those are handled only in Rust code and C++ doesn't need to know about them. Differential Revision: https://phabricator.services.mozilla.com/D9634
See w3c/csswg-drafts#2856. Differential Revision: https://phabricator.services.mozilla.com/D9882
…r tags in the rightmost compound. Before this patch we were only optimizing the case of a single selector, which is fine, but not enough to catch ones like .foo .bar or so. This patch allows us to optimize classes and tags in the rightmost compound, while keeping the current optimization for #id selectors. Need to profile this, but code-wise should be ready for review. Differential Revision: https://phabricator.services.mozilla.com/D9351
Differential Revision: https://phabricator.services.mozilla.com/D10017
See w3c/csswg-drafts#3150 for the issue that would expand this to all pseudos. Differential Revision: https://phabricator.services.mozilla.com/D9994
eqrion/cbindgen#233 changed the way one of the options we use work. I think the new behavior is better, but we should do this sooner rather than later, and fix broken builds. Differential Revision: https://phabricator.services.mozilla.com/D10301
…hen the angle of one is zero. Bug: 1501176 Reviewed-by: hiro
…ndant rust types. We will blacklist this type and add a module raw line to map the gecko type to its rust type (as an alias). Differential Revision: https://phabricator.services.mozilla.com/D10303
So we could avoid generating it in rust-bindgen and drop transmute. Differential Revision: https://phabricator.services.mozilla.com/D10304
Map these two types to their original rust type in rust-bindgen. Differential Revision: https://phabricator.services.mozilla.com/D10141
This needs to update the "fill-rule" and "clip-rule" to use predefined_type to avoid some compilation errors. Differential Revision: https://phabricator.services.mozilla.com/D10142
So we could drop transmute in svg_path related functions. Differential Revision: https://phabricator.services.mozilla.com/D10140
A minor update to drop the redundant "mozilla" namespace prefix in `cbindgen_types` array. Depends on D10305 Differential Revision: https://phabricator.services.mozilla.com/D10325
Differential Revision: https://phabricator.services.mozilla.com/D10327
For now, we keep supporting the prefixed version, since there are examples/instructions on the Web that don't include an unprefixed value. Differential Revision: https://phabricator.services.mozilla.com/D10451
Differential Revision: https://phabricator.services.mozilla.com/D10452
It doesn't make much sense to return const UniquePtr<Foo>& for something that can't be null, it's just confusing. Also make more stuff actually const. Differential Revision: https://phabricator.services.mozilla.com/D10647
When you're in a ShadowRoot and can share style with a sibling, the sharing code is smart enough to skip document author rules. But then it could get confused if you also include document rules, since revalidation selectors are matched against these. This is not a correctness issue, because we're matching more than what we need, and avoid sharing if we failed. Also fix the detection for user rules in any_applicable_rule_data. Differential Revision: https://phabricator.services.mozilla.com/D10117
…ghands. Most of the change is moving sets around to be static functions on LonghandIdSet. I think I like that pattern, but I can also make the new set a global static and add mako code to be `pub` or something. Though I think the LonghandIdSet::foo().contains(..) pattern is nice to read :) Differential Revision: https://phabricator.services.mozilla.com/D10653
Doesn't really need to be in a mako file. Differential Revision: https://phabricator.services.mozilla.com/D10839
…_properties. Similarly, no need to be here. Differential Revision: https://phabricator.services.mozilla.com/D10840
It's nicer, I think. Differential Revision: https://phabricator.services.mozilla.com/D10841
Similarly, the code is not trivial and doesn't really need to be in mako. Differential Revision: https://phabricator.services.mozilla.com/D10842
There are better ways, plus the existing code didn't handle aliases at all (not that it needed to, but it's better if it does). Differential Revision: https://phabricator.services.mozilla.com/D10838
…ies. Being in mako is unnecessary, and makes it harder to debug and such. Differential Revision: https://phabricator.services.mozilla.com/D10843
It's overly generic for no good reason. Differential Revision: https://phabricator.services.mozilla.com/D10844
…a-inset. Intent to Implement and Ship: https://groups.google.com/d/msg/mozilla.dev.platform/EVKyR1B87T0/_l-_qK8SAAAJ Differential Revision: https://phabricator.services.mozilla.com/D9609
It's a bit useless to keep a set of invalid properties if we're going to use them just to reject lookups into another key. This makes it more consistent with the cascade / no-references code, and should not change behavior. Differential Revision: https://phabricator.services.mozilla.com/D9632
bors-servo
added a commit
that referenced
this pull request
Nov 5, 2018
style: Sync changes from mozilla-central. See each individual commit for details. https://bugzilla.mozilla.org/show_bug.cgi?id=1504644
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Nov 5, 2018
style: Sync changes from mozilla-central. See each individual commit for details. https://bugzilla.mozilla.org/show_bug.cgi?id=1504644 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22111) <!-- Reviewable:end -->
|
@bors-servo r+
|
|
|
bors-servo
added a commit
that referenced
this pull request
Nov 5, 2018
style: Sync changes from mozilla-central. See each individual commit for details. https://bugzilla.mozilla.org/show_bug.cgi?id=1504644 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22111) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
|
|
|
|
This was referenced Nov 5, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
emilio commentedNov 5, 2018
•
edited by SimonSapin
See each individual commit for details.
https://bugzilla.mozilla.org/show_bug.cgi?id=1504644
This change is