Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Sync changes from mozilla-central. #22111

Merged
merged 32 commits into from Nov 5, 2018
Merged

style: Sync changes from mozilla-central. #22111

merged 32 commits into from Nov 5, 2018
+1,326 −1,087

Commits on Nov 5, 2018

  1. style: Remove unused style constant. 

    Also remove specified-value-only keywords, since those are handled
only in Rust code and C++ doesn't need to know about them.

Differential Revision: https://phabricator.services.mozilla.com/D9634
    @emilio
    emilio committed Nov 5, 2018
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    26040d1

  2. style: Don't allow auto in grid line names. 

    See w3c/csswg-drafts#2856.

Differential Revision: https://phabricator.services.mozilla.com/D9882
    @emilio
    emilio committed Nov 5, 2018
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    a9af61e

  3. style: Add a fast path for querySelector{,All} when we have classes o… 

    …r tags in the rightmost compound.

Before this patch we were only optimizing the case of a single selector, which
is fine, but not enough to catch ones like .foo .bar or so.

This patch allows us to optimize classes and tags in the rightmost compound,
while keeping the current optimization for #id selectors.

Need to profile this, but code-wise should be ready for review.

Differential Revision: https://phabricator.services.mozilla.com/D9351
    @emilio
    emilio committed Nov 5, 2018
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    a3fcfb6

  4. style: Ignore border-image-source when overriding document colors. 

    Differential Revision: https://phabricator.services.mozilla.com/D10017
    Sean Voisen @emilio
    Sean Voisen authored and emilio committed Nov 5, 2018
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    62aaf86

  5. style: Support ::before / ::after on ::slotted pseudos. 

    See w3c/csswg-drafts#3150 for the issue that would
expand this to all pseudos.

Differential Revision: https://phabricator.services.mozilla.com/D9994
    @emilio
    emilio committed Nov 5, 2018
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    badb8f3

  6. style: Update cbindgen due to breaking change. 

    eqrion/cbindgen#233 changed the way one of the options
we use work.

I think the new behavior is better, but we should do this sooner rather than
later, and fix broken builds.

Differential Revision: https://phabricator.services.mozilla.com/D10301
    @emilio
    emilio committed Nov 5, 2018
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    edf6e6a

  7. style: Interpolate the angle between mis-matched rotate() functions w… 

    …hen the angle of one is zero.

Bug: 1501176
Reviewed-by: hiro
    @birtles @emilio
    birtles authored and emilio committed Nov 5, 2018
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    8bc8a0b

  8. style: Add a special list for cbindgen types to avoid generating redu… 

    …ndant rust types.

We will blacklist this type and add a module raw line to map the gecko
type to its rust type (as an alias).

Differential Revision: https://phabricator.services.mozilla.com/D10303
    @BorisChiou @emilio
    BorisChiou authored and emilio committed Nov 5, 2018
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    b00bbb3

  9. style: Use alias for StyleAppearance. 

    So we could avoid generating it in rust-bindgen and drop transmute.

Differential Revision: https://phabricator.services.mozilla.com/D10304
    @BorisChiou @emilio
    BorisChiou authored and emilio committed Nov 5, 2018
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    591a478

  10. style: Use alias for StyleDisplay and StyleDisplayMode. 

    Map these two types to their original rust type in rust-bindgen.

Differential Revision: https://phabricator.services.mozilla.com/D10141
    @BorisChiou @emilio
    BorisChiou authored and emilio committed Nov 5, 2018
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    cb2533d

  11. style: Use alias for StyleFillRule. 

    This needs to update the "fill-rule" and "clip-rule" to use
predefined_type to avoid some compilation errors.

Differential Revision: https://phabricator.services.mozilla.com/D10142
    @BorisChiou @emilio
    BorisChiou authored and emilio committed Nov 5, 2018
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    c7027e2

  12. style: Use alias for StylePathCommand. 

    So we could drop transmute in svg_path related functions.

Differential Revision: https://phabricator.services.mozilla.com/D10140
    @BorisChiou @emilio
    BorisChiou authored and emilio committed Nov 5, 2018
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    b81bbb8

  13. style: Drop "mozilla" prefix in cbindgen_types in ServoBindings.toml. 

    A minor update to drop the redundant "mozilla" namespace prefix in
`cbindgen_types` array.

Depends on D10305

Differential Revision: https://phabricator.services.mozilla.com/D10325
    @BorisChiou @emilio
    BorisChiou authored and emilio committed Nov 5, 2018
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    33b2514

  14. style: Handle reversed ranges in @font-face descriptors. 

    Differential Revision: https://phabricator.services.mozilla.com/D10327
    @heycam @emilio
    heycam authored and emilio committed Nov 5, 2018
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    5976956

  15. style: Support unprefixed image-rendering: crisp-edges. 

    For now, we keep supporting the prefixed version, since there are examples/instructions
on the Web that don't include an unprefixed value.

Differential Revision: https://phabricator.services.mozilla.com/D10451
    @heycam @emilio
    heycam authored and emilio committed Nov 5, 2018
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    d43c4ce

  16. style: Fix inconsistent CRISPEDGES constant name. 

    Differential Revision: https://phabricator.services.mozilla.com/D10452
    @heycam @emilio
    heycam authored and emilio committed Nov 5, 2018
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    52c3ba0

  17. style: Use references in the shapes code. 

    It doesn't make much sense to return const UniquePtr<Foo>& for something that
can't be null, it's just confusing.

Also make more stuff actually const.

Differential Revision: https://phabricator.services.mozilla.com/D10647
    @emilio
    emilio committed Nov 5, 2018
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    a7b5ba1

  18. style: Don't match document author rules if not needed for revalidation. 

    When you're in a ShadowRoot and can share style with a sibling, the sharing code
is smart enough to skip document author rules.

But then it could get confused if you also include document rules, since
revalidation selectors are matched against these.

This is not a correctness issue, because we're matching more than what we need,
and avoid sharing if we failed.

Also fix the detection for user rules in any_applicable_rule_data.

Differential Revision: https://phabricator.services.mozilla.com/D10117
    @emilio
    emilio committed Nov 5, 2018
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    33fed65

  19. style: Don't keep a separate list of ignored-when-colors-disabled lon… 

    …ghands.

Most of the change is moving sets around to be static functions on
LonghandIdSet. I think I like that pattern, but I can also make the new set a
global static and add mako code to be `pub` or something.

Though I think the LonghandIdSet::foo().contains(..) pattern is nice to read :)

Differential Revision: https://phabricator.services.mozilla.com/D10653
    @emilio
    emilio committed Nov 5, 2018
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    d035d02

  20. style: Move shorthand IDL order stuff out of animated_properties. 

    Doesn't really need to be in a mako file.

Differential Revision: https://phabricator.services.mozilla.com/D10839
    @emilio
    emilio committed Nov 5, 2018
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    282edf1

  21. style: Move the keyframes property priority stuff outside of animated… 

    …_properties.

Similarly, no need to be here.

Differential Revision: https://phabricator.services.mozilla.com/D10840
    @emilio
    emilio committed Nov 5, 2018
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    f159c20

  22. style: Move various length animation implementations to its own file. 

    It's nicer, I think.

Differential Revision: https://phabricator.services.mozilla.com/D10841
    @emilio
    emilio committed Nov 5, 2018
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    778ae7d

  23. style: Move various font-related animation code to its own file. 

    Similarly, the code is not trivial and doesn't really need to be in
mako.

Differential Revision: https://phabricator.services.mozilla.com/D10842
    @emilio
    emilio committed Nov 5, 2018
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    707bd84

  24. style: Remove nscsspropertyid_is_{animatable,transitionable}. 

    There are better ways, plus the existing code didn't handle aliases at
all (not that it needed to, but it's better if it does).

Differential Revision: https://phabricator.services.mozilla.com/D10838
    @emilio
    emilio committed Nov 5, 2018
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    8b49ef8

  25. style: Move animation of svg-related bits outside of animated_propert… 

    …ies.

Being in mako is unnecessary, and makes it harder to debug and such.

Differential Revision: https://phabricator.services.mozilla.com/D10843
    @emilio
    emilio committed Nov 5, 2018
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    c88a483

  26. style: Simplify the SVG animation code. 

    It's overly generic for no good reason.

Differential Revision: https://phabricator.services.mozilla.com/D10844
    @emilio
    emilio committed Nov 5, 2018
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    5af6abf

  27. style: Implement the env() function with hardcoded zeros for safe-are… 

    …a-inset.

Intent to Implement and Ship: https://groups.google.com/d/msg/mozilla.dev.platform/EVKyR1B87T0/_l-_qK8SAAAJ

Differential Revision: https://phabricator.services.mozilla.com/D9609
    @emilio
    emilio committed Nov 5, 2018
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    b7da1ba

  28. style: Simplify invalid custom property handling. 

    It's a bit useless to keep a set of invalid properties if we're going
to use them just to reject lookups into another key. This makes it more
consistent with the cascade / no-references code, and should not change
behavior.

Differential Revision: https://phabricator.services.mozilla.com/D9632
    @emilio
    emilio committed Nov 5, 2018
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    99f9d84

  29. Update remaining references to cssparser 0.24.

    @emilio
    emilio committed Nov 5, 2018
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    29f5691

  30. Fix tidy issues.

    @emilio
    emilio committed Nov 5, 2018
    Loading status checks…
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    8560c8d

  31. style: Add the safe area constant names as atoms.

    @emilio
    emilio committed Nov 5, 2018
    Loading status checks…
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    64e70e2

  32. style: Fix servo build.

    @emilio
    emilio committed Nov 5, 2018
    Loading status checks…
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    ac6f921
You can’t perform that action at this time.