New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement WEBGL_color_buffer_float and EXT_color_buffer_half_float #22112

Merged
merged 1 commit into from Nov 6, 2018

Conversation

5 participants
@nox
Member

nox commented Nov 5, 2018

This change is Reviewable

@highfive

This comment has been minimized.

highfive commented Nov 5, 2018

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/webgl_extensions/ext/oestexturefloat.rs, components/script/dom/webidls/EXTColorBufferHalfFloat.webidl, components/script/dom/webgl_extensions/extensions.rs, components/script/dom/webgl_extensions/ext/mod.rs, components/script/dom/webidls/WEBGLColorBufferFloat.webidl and 5 more
  • @jgraham: tests/wpt/webgl/meta/conformance/extensions/oes-texture-float.html.ini, tests/wpt/webgl/meta/conformance/extensions/oes-texture-half-float.html.ini
  • @KiChjang: components/script/dom/webgl_extensions/ext/oestexturefloat.rs, components/script/dom/webidls/EXTColorBufferHalfFloat.webidl, components/script/dom/webgl_extensions/extensions.rs, components/script/dom/webgl_extensions/ext/mod.rs, components/script/dom/webidls/WEBGLColorBufferFloat.webidl and 5 more
@jdm

This comment has been minimized.

Member

jdm commented Nov 5, 2018

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 5, 2018

📌 Commit e31462c has been approved by jdm

@highfive highfive assigned jdm and unassigned asajeffrey Nov 5, 2018

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 5, 2018

⌛️ Testing commit e31462c with merge 2c49830...

bors-servo added a commit that referenced this pull request Nov 5, 2018

Auto merge of #22112 - servo:webgl, r=jdm
Implement WEBGL_color_buffer_float and EXT_color_buffer_half_float

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22112)
<!-- Reviewable:end -->
@jdm

This comment has been minimized.

Member

jdm commented Nov 6, 2018

@bors-servo retry

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 6, 2018

⌛️ Testing commit e31462c with merge c3f2f38...

bors-servo added a commit that referenced this pull request Nov 6, 2018

Auto merge of #22112 - servo:webgl, r=jdm
Implement WEBGL_color_buffer_float and EXT_color_buffer_half_float

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22112)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 6, 2018

💔 Test failed - android-x86

@highfive

This comment has been minimized.

highfive commented Nov 6, 2018

  ▶ TIMEOUT [expected OK] /_mozilla/mozilla/DOMParser.html
@jdm

This comment has been minimized.

Member

jdm commented Nov 6, 2018

@bors-servo retry

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 6, 2018

⌛️ Testing commit e31462c with merge 7a3daac...

bors-servo added a commit that referenced this pull request Nov 6, 2018

Auto merge of #22112 - servo:webgl, r=jdm
Implement WEBGL_color_buffer_float and EXT_color_buffer_half_float

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22112)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 6, 2018

@bors-servo bors-servo merged commit e31462c into master Nov 6, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@atouchet atouchet added this to Done in WebGL content Nov 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment