Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement WEBGL_color_buffer_float and EXT_color_buffer_half_float #22112

Merged
merged 1 commit into from Nov 6, 2018
Merged

Implement WEBGL_color_buffer_float and EXT_color_buffer_half_float #22112

merged 1 commit into from Nov 6, 2018

Conversation

@nox
Copy link
Member

nox commented Nov 5, 2018 •
edited by SimonSapin

This change is Reviewable
@highfive
Copy link

highfive commented Nov 5, 2018

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/webgl_extensions/ext/oestexturefloat.rs, components/script/dom/webidls/EXTColorBufferHalfFloat.webidl, components/script/dom/webgl_extensions/extensions.rs, components/script/dom/webgl_extensions/ext/mod.rs, components/script/dom/webidls/WEBGLColorBufferFloat.webidl and 5 more
  • @jgraham: tests/wpt/webgl/meta/conformance/extensions/oes-texture-float.html.ini, tests/wpt/webgl/meta/conformance/extensions/oes-texture-half-float.html.ini
  • @KiChjang: components/script/dom/webgl_extensions/ext/oestexturefloat.rs, components/script/dom/webidls/EXTColorBufferHalfFloat.webidl, components/script/dom/webgl_extensions/extensions.rs, components/script/dom/webgl_extensions/ext/mod.rs, components/script/dom/webidls/WEBGLColorBufferFloat.webidl and 5 more
@jdm @nox
Implement WEBGL_color_buffer_float and EXT_color_buffer_half_float (f…
Loading status checks…
e31462c 
…ixes #22113)
@nox nox force-pushed the webgl branch from 495e085 to e31462c Nov 5, 2018
@nox nox mentioned this pull request Nov 5, 2018
Closed
@jdm
Copy link
Member

jdm commented Nov 5, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Nov 5, 2018

📌 Commit e31462c has been approved by jdm
@highfive highfive assigned jdm and unassigned asajeffrey Nov 5, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Nov 5, 2018

⌛ Testing commit e31462c with merge 2c49830...
bors-servo added a commit that referenced this pull request Nov 5, 2018
@bors-servo
Auto merge of #22112 - servo:webgl, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
2c49830 
Implement WEBGL_color_buffer_float and EXT_color_buffer_half_float

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22112)
<!-- Reviewable:end -->
@jdm
Copy link
Member

jdm commented Nov 6, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Nov 6, 2018

⌛ Testing commit e31462c with merge c3f2f38...
bors-servo added a commit that referenced this pull request Nov 6, 2018
@bors-servo
Auto merge of #22112 - servo:webgl, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c3f2f38 
Implement WEBGL_color_buffer_float and EXT_color_buffer_half_float

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22112)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 6, 2018

💔 Test failed - android-x86
@highfive
Copy link

highfive commented Nov 6, 2018 

  ▶ TIMEOUT [expected OK] /_mozilla/mozilla/DOMParser.html
@jdm
Copy link
Member

jdm commented Nov 6, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Nov 6, 2018

⌛ Testing commit e31462c with merge 7a3daac...
bors-servo added a commit that referenced this pull request Nov 6, 2018
@bors-servo
Auto merge of #22112 - servo:webgl, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7a3daac 
Implement WEBGL_color_buffer_float and EXT_color_buffer_half_float

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22112)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 6, 2018

☀️ Test successful - android, android-mac, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: jdm
Pushing 7a3daac to master...
@bors-servo bors-servo merged commit e31462c into master Nov 6, 2018
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@atouchet atouchet added this to Done in WebGL content Nov 6, 2018
@nox nox mentioned this pull request Nov 20, 2018
Closed
@jdm jdm mentioned this pull request May 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
WebGL content
  
Done
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@nox @highfive @jdm @bors-servo @asajeffrey
You can’t perform that action at this time.