New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add magicleap builder #22117

Merged
merged 1 commit into from Nov 6, 2018

Conversation

Projects
None yet
5 participants
@asajeffrey
Member

asajeffrey commented Nov 5, 2018

Add a magicleap builder to etc/ci/buildbot_steps.yml to gate releases on building the magicleap library. This doesn't yet check for building the magicleap app, or add a nightly release. That'll be a later PR.


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes do not require tests because it's adding a build test

This change is Reviewable

@highfive

This comment has been minimized.

highfive commented Nov 5, 2018

Heads up! This PR modifies the following files:

@asajeffrey

This comment has been minimized.

Member

asajeffrey commented Nov 5, 2018

Depends on servo/saltfs#908.

@jdm

This comment has been minimized.

Member

jdm commented Nov 5, 2018

Let's merge this first so that subsequent builds don't get messed up after we deploy the saltfs changes.

@jdm

This comment has been minimized.

Member

jdm commented Nov 5, 2018

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 5, 2018

📌 Commit e57859f has been approved by jdm

@highfive highfive assigned jdm and unassigned paulrouget Nov 5, 2018

@asajeffrey asajeffrey referenced this pull request Nov 5, 2018

Merged

Add magicleap builders #910

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 6, 2018

⌛️ Testing commit e57859f with merge 535ea96...

bors-servo added a commit that referenced this pull request Nov 6, 2018

Auto merge of #22117 - asajeffrey:magicleap-ci, r=jdm
Add magicleap builder

<!-- Please describe your changes on the following line: -->

Add a magicleap builder to `etc/ci/buildbot_steps.yml` to gate releases on building the magicleap library. This doesn't yet check for building the magicleap app, or add a nightly release. That'll be a later PR.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because it's adding a build test

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22117)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 6, 2018

💔 Test failed - linux-rel-css

@jdm

This comment has been minimized.

Member

jdm commented Nov 6, 2018

@bors-servo retry

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 6, 2018

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 6, 2018

@bors-servo bors-servo merged commit e57859f into servo:master Nov 6, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@asajeffrey asajeffrey referenced this pull request Nov 6, 2018

Closed

Magic Leap build in CI #22078

3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment