Remove sync constellation -> embedder communication #22121

gterzian · 2018-11-06T11:01:20Z

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes fix #22042 (github issue number if applicable).

There are tests for these changes OR
These changes do not require tests because _____

This change is

highfive · 2018-11-06T11:01:24Z

Heads up! This PR modifies the following files:

@asajeffrey: components/constellation/constellation.rs
@cbrewster: components/constellation/constellation.rs
@paulrouget: ports/servo/browser.rs, components/constellation/constellation.rs, components/compositing/windowing.rs, components/servo/lib.rs
@KiChjang: components/script_traits/lib.rs

gterzian · 2018-11-06T11:23:14Z

@bors-servo try

bors-servo · 2018-11-06T11:23:19Z

⌛ Trying commit e7484a8 with merge 0f36863...


        Auto merge of #22121 - gterzian:remove_constellation_block_in_navigat…

…ion, r=<try> Remove sync constellation -> embedder communication  ---  - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #22042 (github issue number if applicable).  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22121)

gterzian · 2018-11-06T11:33:41Z

@jdm this is the only case of recv() involving a channel send inside an EmbedderMsg I could find in the constellation(there are some other cases involving canvas and layout however).

In the case of the unloading of a document, or the opening of an auxiliary, it's the script-thread that sends the EmbedderMsg(via a forwarding by the constellation), and blocks waiting on the reply from the embedder...

bors-servo · 2018-11-06T11:34:29Z

💔 Test failed - status-taskcluster

gterzian · 2018-11-07T05:51:59Z

@bors-servo try

bors-servo · 2018-11-07T05:52:04Z

⌛ Trying commit 629fe8e with merge 4bc5201...


        Auto merge of #22121 - gterzian:remove_constellation_block_in_navigat…

…ion, r=<try> Remove sync constellation -> embedder communication  ---  - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #22042 (github issue number if applicable).  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22121)

bors-servo · 2018-11-07T06:03:59Z

💔 Test failed - status-taskcluster

gterzian · 2018-11-07T06:40:47Z

{"status": "TIMEOUT", "group": "default", "message": null, "stack": null, "subtest": null, "test": "/html/browsers/browsing-the-web/unloading-documents/unload/002.html", "line": 105047, "action": "test_result", "expected": "OK"}
{"status": "TIMEOUT", "group": "default", "message": null, "stack": null, "subtest": null, "test": "/html/browsers/browsing-the-web/navigating-across-documents/source/navigate-child-function.html", "line": 105249, "action": "test_result", "expected": "OK"}
{"status": "ERROR", "group": "default", "message": "Got results from /html/browsers/browsing-the-web/history-traversal/support/window-name-test.sub.html?shouldhavename=true&sendmessage=true, expected /html/browsers/browsing-the-web/history-traversal/window-name-after-cross-origin-sub-frame-navigation.sub.html\nTraceback (most recent call last):\n  File \"/home/servo/buildbot/slave/linux-rel-css/build/tests/wpt/web-platform-tests/tools/wptrunner/wptrunner/executors/base.py\", line 162, in run_test\n    result = self.do_test(test)\n  File \"/home/servo/buildbot/slave/linux-rel-css/build/tests/wpt/web-platform-tests/tools/wptrunner/wptrunner/executors/executorservo.py\", line 110, in do_test\n    result = self.convert_result(test, self.result_data)\n  File \"/home/servo/buildbot/slave/linux-rel-css/build/tests/wpt/web-platform-tests/tools/wptrunner/wptrunner/executors/base.py\", line 69, in __call__\n    (result_url, test.url))\nAssertionError: Got results from /html/browsers/browsing-the-web/history-traversal/support/window-name-test.sub.html?shouldhavename=true&sendmessage=true, expected /html/browsers/browsing-the-web/history-traversal/window-name-after-cross-origin-sub-frame-navigation.sub.html\n", "stack": null, "subtest": null, "test": "/html/browsers/browsing-the-web/history-traversal/window-name-after-cross-origin-sub-frame-navigation.sub.html", "line": 105297, "action": "test_result", "expected": "OK"}
{"status": "TIMEOUT", "group": "default", "message": null, "stack": null, "subtest": null, "test": "/html/semantics/forms/form-submission-0/getactionurl.html", "line": 105537, "action": "test_result", "expected": "OK"}

Given all those timeouts, and more, it looks likes something is wrong...

gterzian · 2018-11-07T07:33:17Z

@bors-servo try

bors-servo · 2018-11-07T07:33:22Z

⌛ Trying commit 610bbe3 with merge a38dfc2...


        Auto merge of #22121 - gterzian:remove_constellation_block_in_navigat…

…ion, r=<try> Remove sync constellation -> embedder communication  ---  - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #22042 (github issue number if applicable).  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22121)

bors-servo · 2018-11-07T08:00:07Z

💔 Test failed - linux-rel-css

servo-wpt-sync · 2018-12-23T05:26:50Z

No upstreamable changes; closed existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#14658.


        constellation: restructure navigation, remove sync comm

gterzian · 2018-12-23T05:35:49Z

@bors-servo try

bors-servo · 2018-12-23T05:35:54Z

⌛ Trying commit fbfaa16 with merge 9357720...


        Auto merge of #22121 - gterzian:remove_constellation_block_in_navigat…

…ion, r=<try> Remove sync constellation -> embedder communication  ---  - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #22042 (github issue number if applicable).  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22121)

bors-servo · 2018-12-23T07:15:51Z

☀️ Test successful - android-mac, arm32, arm64, linux-rel-css, linux-rel-wpt, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster
State: approved= try=True

gterzian · 2018-12-23T09:18:14Z

Ok, this is what I have done:

Turned the panic into a warning(which is consistent to what was already there): https://github.com/servo/servo/pull/22121/files#diff-55c92a6a5ba7654ce45fe6fc6c63740fR1062
Only checking this "delaying load events mode" if there is actually a browsing context, avoiding the panic: https://github.com/servo/servo/pull/22121/files#diff-30a18e04d7e0b66aafdf192e416cad44R1914
Added a new commit for something I came across while debugging the latest, seems like a straightforward change based on the spec. See step4 of https://html.spec.whatwg.org/multipage/parsing.html#abort-a-parser


        implement windowproxy "delay-load-event-mode", and partially document…

… "completely-loaded"


        check for a document being "fully-active" before reflows


        set document ready state to complete in step 4 of parser abort

gterzian · 2018-12-23T09:40:57Z

Added this check for consistency(even though it hadn't crashed at that point yet for lack of a browsing context, like it did in maybe_queue_document_load) eb82e78#diff-1879ac6bd5d567e2aa43529d33474677R2090

paulrouget · 2018-12-26T06:37:33Z

@bors-servo r+

bors-servo · 2018-12-26T06:37:34Z

📌 Commit cca354b has been approved by paulrouget

bors-servo · 2018-12-26T06:53:23Z

⌛ Testing commit cca354b with merge 66223ee...


        Auto merge of #22121 - gterzian:remove_constellation_block_in_navigat…

…ion, r=paulrouget Remove sync constellation -> embedder communication  ---  - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #22042 (github issue number if applicable).  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22121)

bors-servo · 2018-12-26T07:18:44Z

💔 Test failed - linux-rel-wpt

gterzian · 2018-12-26T10:35:20Z

@bors-servo retry

#22559 (this one is related, yet really intermittent, cannot reproduce)
#22560

bors-servo · 2018-12-26T10:35:23Z

⚡ Previous build results for android-mac, arm32, arm64, linux-rel-css, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster are reusable. Rebuilding only linux-rel-wpt, mac-rel-css1...

bors-servo · 2018-12-26T11:16:27Z

☀️ Test successful - android-mac, arm32, arm64, linux-rel-css, linux-rel-wpt, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster
Approved by: paulrouget
Pushing 66223ee to master...

highfive assigned ferjm Nov 6, 2018

highfive added the S-awaiting-review label Nov 6, 2018

gterzian force-pushed the gterzian:remove_constellation_block_in_navigation branch from 5029901 to e7484a8 Nov 6, 2018

highfive added the S-tests-failed label Nov 6, 2018

gterzian force-pushed the gterzian:remove_constellation_block_in_navigation branch from e7484a8 to bd55e0f Nov 6, 2018

highfive removed the S-tests-failed label Nov 6, 2018

gterzian force-pushed the gterzian:remove_constellation_block_in_navigation branch 2 times, most recently from 3f39521 to 629fe8e Nov 6, 2018

highfive added the S-tests-failed label Nov 7, 2018

gterzian force-pushed the gterzian:remove_constellation_block_in_navigation branch from 629fe8e to 035c4e1 Nov 7, 2018

highfive removed the S-tests-failed label Nov 7, 2018

paulrouget assigned paulrouget and unassigned ferjm Nov 7, 2018

gterzian force-pushed the gterzian:remove_constellation_block_in_navigation branch from 035c4e1 to 610bbe3 Nov 7, 2018

highfive added the S-tests-failed label Nov 7, 2018

constellation: restructure navigation, remove sync comm

483bf24

gterzian force-pushed the gterzian:remove_constellation_block_in_navigation branch from f638c84 to fbfaa16 Dec 23, 2018

gterzian force-pushed the gterzian:remove_constellation_block_in_navigation branch from fbfaa16 to 5dca870 Dec 23, 2018

gterzian added 3 commits Dec 12, 2018

implement windowproxy "delay-load-event-mode", and partially document…

eb82e78

… "completely-loaded"

check for a document being "fully-active" before reflows

7530faa

set document ready state to complete in step 4 of parser abort

Loading status checks…

cca354b

gterzian force-pushed the gterzian:remove_constellation_block_in_navigation branch from 5dca870 to cca354b Dec 23, 2018

highfive added S-awaiting-merge and removed S-awaiting-review labels Dec 26, 2018

highfive added S-tests-failed and removed S-awaiting-merge labels Dec 26, 2018

bors-servo merged commit cca354b into servo:master Dec 26, 2018
2 of 3 checks passed

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

This was referenced Dec 26, 2018

Add support for market:// urls #22091

Closed

Upgrade to rustc 1.33.0-nightly (fb86d604b 2018-12-27) #22385

Merged

gterzian deleted the gterzian:remove_constellation_block_in_navigation branch Dec 27, 2018

servo / servo

Remove sync constellation -> embedder communication #22121

Remove sync constellation -> embedder communication #22121

gterzian commented Nov 6, 2018 •

edited by SimonSapin

highfive commented Nov 6, 2018

gterzian commented Nov 6, 2018

bors-servo commented Nov 6, 2018

gterzian commented Nov 6, 2018

bors-servo commented Nov 6, 2018

gterzian commented Nov 7, 2018

bors-servo commented Nov 7, 2018

bors-servo commented Nov 7, 2018

gterzian commented Nov 7, 2018

gterzian commented Nov 7, 2018

bors-servo commented Nov 7, 2018

bors-servo commented Nov 7, 2018

servo-wpt-sync commented Dec 23, 2018

gterzian commented Dec 23, 2018

bors-servo commented Dec 23, 2018

bors-servo commented Dec 23, 2018

gterzian commented Dec 23, 2018

gterzian commented Dec 23, 2018

paulrouget commented Dec 26, 2018

bors-servo commented Dec 26, 2018

bors-servo commented Dec 26, 2018

bors-servo commented Dec 26, 2018

gterzian commented Dec 26, 2018

bors-servo commented Dec 26, 2018

bors-servo commented Dec 26, 2018

servo / servo

Join GitHub today

Remove sync constellation -> embedder communication #22121

Remove sync constellation -> embedder communication #22121

Conversation

gterzian commented Nov 6, 2018 • edited by SimonSapin

highfive commented Nov 6, 2018

gterzian commented Nov 6, 2018

bors-servo commented Nov 6, 2018

gterzian commented Nov 6, 2018

bors-servo commented Nov 6, 2018

gterzian commented Nov 7, 2018

bors-servo commented Nov 7, 2018

bors-servo commented Nov 7, 2018

gterzian commented Nov 7, 2018

gterzian commented Nov 7, 2018

bors-servo commented Nov 7, 2018

bors-servo commented Nov 7, 2018

servo-wpt-sync commented Dec 23, 2018

gterzian commented Dec 23, 2018

bors-servo commented Dec 23, 2018

bors-servo commented Dec 23, 2018

gterzian commented Dec 23, 2018

gterzian commented Dec 23, 2018

paulrouget commented Dec 26, 2018

bors-servo commented Dec 26, 2018

bors-servo commented Dec 26, 2018

bors-servo commented Dec 26, 2018

gterzian commented Dec 26, 2018

bors-servo commented Dec 26, 2018

bors-servo commented Dec 26, 2018

gterzian commented Nov 6, 2018 •

edited by SimonSapin