Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Sync changes from mozilla-central. #22143

Merged
merged 11 commits into from Nov 8, 2018
Merged

style: Sync changes from mozilla-central. #22143

merged 11 commits into from Nov 8, 2018

Conversation

@emilio
Copy link
Member

emilio commented Nov 7, 2018 •
edited by SimonSapin

See each individual commit for details.

This change is Reviewable
@highfive
Copy link

highfive commented Nov 7, 2018

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style code, but no tests are modified. Please consider adding a test!
@emilio emilio force-pushed the emilio:gecko-sync branch from c335692 to 0a2fb7c Nov 7, 2018
@emilio
Copy link
Member Author

emilio commented Nov 7, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Nov 7, 2018

📌 Commit 0a2fb7c has been approved by emilio
@highfive highfive assigned emilio and unassigned ferjm Nov 7, 2018
@emilio
Copy link
Member Author

emilio commented Nov 8, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Nov 8, 2018

📌 Commit d7420fa has been approved by emilio
@bors-servo
Copy link
Contributor

bors-servo commented Nov 8, 2018

⌛ Testing commit d7420fa with merge 81c496b...
bors-servo added a commit that referenced this pull request Nov 8, 2018
@bors-servo
Auto merge of #22143 - emilio:gecko-sync, r=emilio
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
81c496b 
style: Sync changes from mozilla-central.

See each individual commit for details.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22143)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 8, 2018

💔 Test failed - linux-rel-wpt
@CYBAI
Copy link
Collaborator

CYBAI commented Nov 8, 2018 

{"status": "PASS", "group": "default", "message": null, "stack": null, "subtest": "background_specified_color_size", "test": "/css/css-backgrounds/background-333.html", "line": 116777, "action": "test_result", "expected": "FAIL"}
{"status": "PASS", "group": "default", "message": null, "stack": null, "subtest": "background_initial_size", "test": "/css/css-backgrounds/background-331.html", "line": 134036, "action": "test_result", "expected": "FAIL"}
{"status": "PASS", "group": "default", "message": null, "stack": null, "subtest": "background-size_initial", "test": "/css/css-backgrounds/background-size-001.html", "line": 141829, "action": "test_result", "expected": "FAIL"}
{"status": "PASS", "group": "default", "message": null, "stack": null, "subtest": "background-size_auto", "test": "/css/css-backgrounds/background-size-001.html", "line": 141830, "action": "test_result", "expected": "FAIL"}
{"status": "FAIL", "group": "default", "message": "assert_equals: background-size supporting value expected \"auto auto\" but got \"auto\"", "stack": "@http://web-platform.test:8000/css/css-backgrounds/background-size-001.html:83:13\nTest.prototype.step@http://web-platform.test:8000/resources/testharness.js:1568:20\ntest@http://web-platform.test:8000/resources/testharness.js:544:21\n@http://web-platform.test:8000/css/css-backgrounds/background-size-001.html:82:9\n", "subtest": "background-size_auto_auto", "test": "/css/css-backgrounds/background-size-001.html", "line": 141840, "action": "test_result", "expected": "PASS"}
aethanyc and others added 8 commits Nov 5, 2018
@aethanyc @emilio
style: Remove preference "layout.css.shape-outside.enabled".
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
68f4ad9 
shape-outside, shape-margin, shape-image-threshold have been shipped in Firefox
62. We can remove the preference.

The change in devtools/shared/css/generated/properties-db.js is generated by
"./mach devtools-css-db"

The actual shape-image CORS mode tests in file_shape_outside_CORS.html are
moved into test_shape_outside_CORS.html because we don't need the <iframe>
trick to enable the feature.

Differential Revision: https://phabricator.services.mozilla.com/D10804
@heycam @emilio
style: Serialize `background-size: auto auto` as "auto".
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
56fd3b7 
With this change, all of Chrome, Edge, Firefox, and Safari serialize
background-size by omitting the second "auto" if the value is "auto
auto".  Other keywords are still repeated.

Differential Revision: https://phabricator.services.mozilla.com/D10446
@heycam @emilio
style: Make quotes property representation allocate less.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
acf7b65 
Differential Revision: https://phabricator.services.mozilla.com/D10650
@heycam @emilio
style: Store the Rust QuotePair slice as the computed quotes value in…
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
de5584c 
… Gecko style structs.

Depends on D10651

Differential Revision: https://phabricator.services.mozilla.com/D10652
@emilio
style: followup post-review nit.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
264a679
@BorisChiou @emilio
style: Fix the default behavior of scale:<number>{1}.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
23f2e99 
The current spec says: "If only the X value is given, the Y value
defaults to the same value.", so we should update the behavior.

Besides, we also update the serialization, so we serialization both
specified and computed value by servo. We enable the preference
for all the css-transforms, so some of them are passed now.

Differential Revision: https://phabricator.services.mozilla.com/D10638
@emilio
style: Fix code style of a recent commit.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
efa54a8
@emilio
style: Format recent patches.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
175e594
@jdm
Copy link
Member

jdm commented Nov 8, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Nov 8, 2018

💣 Failed to start rebuilding: Unknown error
3 similar comments
@bors-servo
Copy link
Contributor

bors-servo commented Nov 8, 2018

💣 Failed to start rebuilding: Unknown error
@bors-servo
Copy link
Contributor

bors-servo commented Nov 8, 2018

💣 Failed to start rebuilding: Unknown error
@bors-servo
Copy link
Contributor

bors-servo commented Nov 8, 2018

💣 Failed to start rebuilding: Unknown error
@jdm
Copy link
Member

jdm commented Nov 8, 2018

@bors-servo try-
@jdm
Copy link
Member

jdm commented Nov 8, 2018

@bors-servo retry
@jdm
Copy link
Member

jdm commented Nov 8, 2018

@bors-servo r-
@jdm
Copy link
Member

jdm commented Nov 8, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Nov 8, 2018

📌 Commit c96df0f has been approved by jdm
@jdm
Copy link
Member

jdm commented Nov 8, 2018

@bors-servo r-
@jdm
Copy link
Member

jdm commented Nov 8, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Nov 8, 2018

📌 Commit c96df0f has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Nov 8, 2018

⌛ Testing commit c96df0f with merge 2aeefe8...
bors-servo added a commit that referenced this pull request Nov 8, 2018
@bors-servo
Auto merge of #22143 - emilio:gecko-sync, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
2aeefe8 
style: Sync changes from mozilla-central.

See each individual commit for details.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22143)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 8, 2018

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Nov 8, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Nov 8, 2018

⌛ Testing commit c96df0f with merge bb2c5e3...
bors-servo added a commit that referenced this pull request Nov 8, 2018
@bors-servo
Auto merge of #22143 - emilio:gecko-sync, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
bb2c5e3 
style: Sync changes from mozilla-central.

See each individual commit for details.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22143)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 8, 2018

☀️ Test successful - android, android-mac, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: jdm
Pushing bb2c5e3 to master...
@bors-servo bors-servo merged commit c96df0f into servo:master Nov 8, 2018
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Nov 8, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

9 participants
@emilio @highfive @bors-servo @CYBAI @jdm @ferjm @aethanyc @heycam @BorisChiou
You can’t perform that action at this time.