Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a streaming base64 encoder in canvas.toDataURL #22147

Closed
wants to merge 1 commit into from
Closed

Use a streaming base64 encoder in canvas.toDataURL #22147

wants to merge 1 commit into from

Conversation

@nox
Copy link
Member

nox commented Nov 8, 2018 •
edited by SimonSapin

This change is Reviewable
@highfive
Copy link

highfive commented Nov 8, 2018

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/Cargo.toml, components/script/dom/htmlcanvaselement.rs, components/webdriver_server/Cargo.toml
  • @jgraham: components/webdriver_server/Cargo.toml
  • @edunham: servo-tidy.toml
  • @KiChjang: components/net/Cargo.toml, components/script/Cargo.toml, components/script/dom/htmlcanvaselement.rs
@highfive
Copy link

highfive commented Nov 8, 2018

warning Warning warning

  • These commits modify net and script code, but no tests are modified. Please consider adding a test!
@nox nox force-pushed the base64 branch from f770488 to ba9f2f4 Nov 8, 2018
nox added a commit that referenced this pull request Nov 8, 2018
@nox
Use a streaming base64 encoder in canvas.toDataURL (fixes #22147)
Loading status checks…
ba9f2f4
@bors-servo
Copy link
Contributor

bors-servo commented Nov 9, 2018

☔ The latest upstream changes (presumably #22151) made this pull request unmergeable. Please resolve the merge conflicts.
@jdm
jdm approved these changes Nov 9, 2018
View changes
@jdm jdm removed the S-awaiting-review label Nov 9, 2018
@nox nox force-pushed the base64 branch from ba9f2f4 to de54aef Nov 9, 2018
nox added a commit that referenced this pull request Nov 9, 2018
@nox
Use a streaming base64 encoder in canvas.toDataURL (fixes #22147)
Loading status checks…
de54aef
@nox
Copy link
Member Author

nox commented Nov 9, 2018

@bors-servo r=jdm
@bors-servo
Copy link
Contributor

bors-servo commented Nov 9, 2018

📌 Commit de54aef has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Nov 9, 2018

⌛ Testing commit de54aef with merge c3956f8...
bors-servo added a commit that referenced this pull request Nov 9, 2018
@bors-servo
Auto merge of #22147 - servo:base64, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c3956f8 
Use a streaming base64 encoder in canvas.toDataURL

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22147)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 9, 2018

💔 Test failed - linux-rel-css
@nox
Copy link
Member Author

nox commented Nov 9, 2018

Seems like I broke something or the encoder is broken.
@jdm
Copy link
Member

jdm commented Nov 9, 2018

@bors-servo r-
@nox nox mentioned this pull request Nov 13, 2018
Merged
@nox
Copy link
Member Author

nox commented Nov 13, 2018

image-rs/image-png#94
@bors-servo
Copy link
Contributor

bors-servo commented Nov 18, 2018

☔ The latest upstream changes (presumably #22209) made this pull request unmergeable. Please resolve the merge conflicts.
@nox
Use a streaming base64 encoder in canvas.toDataURL (fixes #22147)
Loading status checks…
40d0016
@nox nox force-pushed the base64 branch from de54aef to 40d0016 Nov 21, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Nov 21, 2018

☔ The latest upstream changes (presumably #22225) made this pull request unmergeable. Please resolve the merge conflicts.
@atouchet
Copy link
Contributor

atouchet commented Nov 29, 2018 •
edited

png 0.13.2 is now out.

Edit: I guess image-rs/image#837 still needs to be merged as well.
@nox
Copy link
Member Author

nox commented Jan 23, 2019

I will reopen this when the 24,787 blockers are fixed.
@nox nox closed this Jan 23, 2019
@nox nox deleted the base64 branch Jan 23, 2019
@atouchet
Copy link
Contributor

atouchet commented Mar 22, 2019

image and png were updated in #22973. Is there anything else blocking this?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdm jdm

Assignees

@jdm jdm

Labels
S-blocked-on-external S-needs-rebase
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@nox @highfive @bors-servo @jdm @atouchet
You can’t perform that action at this time.