Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement rejectionhandled event #22149

Merged
merged 3 commits into from Nov 15, 2018
Merged

Implement rejectionhandled event #22149

merged 3 commits into from Nov 15, 2018

Conversation

@CYBAI
Copy link
Collaborator

CYBAI commented Nov 8, 2018 •
edited by SimonSapin

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #22006 .
  • There are more tests PASSed for these changes

This change is Reviewable
@highfive
Copy link

highfive commented Nov 8, 2018

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/Cargo.toml, components/script/script_runtime.rs
  • @KiChjang: components/script/Cargo.toml, components/script/script_runtime.rs
@jdm jdm added the S-needs-rebase label Nov 8, 2018
@CYBAI CYBAI force-pushed the CYBAI:rejectionhandled branch from f66ed54 to 427fdb9 Nov 8, 2018
@CYBAI CYBAI removed the S-needs-rebase label Nov 8, 2018
@CYBAI
Copy link
Collaborator Author

CYBAI commented Nov 8, 2018

@bors-servo try=wpt
bors-servo added a commit that referenced this pull request Nov 8, 2018
@bors-servo
Auto merge of #22149 - CYBAI:rejectionhandled, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b03aee5 
Implement rejectionhandled event

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22006 .
- [x] There are more tests `PASS`ed for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22149)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 8, 2018

⌛ Trying commit 427fdb9 with merge b03aee5...
@jdm
Copy link
Member

jdm commented Nov 8, 2018

@bors-servo retry
@jdm
Copy link
Member

jdm commented Nov 8, 2018

@bors-servo try=wpt
@jdm
Copy link
Member

jdm commented Nov 8, 2018

@bors-servo try-
@jdm
Copy link
Member

jdm commented Nov 8, 2018

@bors-servo try=wpt
1 similar comment
@jdm
Copy link
Member

jdm commented Nov 8, 2018

@bors-servo try=wpt
@bors-servo
Copy link
Contributor

bors-servo commented Nov 8, 2018

⌛ Trying commit 427fdb9 with merge 66f7549...
bors-servo added a commit that referenced this pull request Nov 8, 2018
@bors-servo
Auto merge of #22149 - CYBAI:rejectionhandled, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
66f7549 
Implement rejectionhandled event

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22006 .
- [x] There are more tests `PASS`ed for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22149)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 8, 2018

💔 Test failed - linux-rel-css
@CYBAI CYBAI force-pushed the CYBAI:rejectionhandled branch from 427fdb9 to 3f394bf Nov 10, 2018
@CYBAI
Copy link
Collaborator Author

CYBAI commented Nov 10, 2018

@bors-servo try=wpt
@bors-servo
Copy link
Contributor

bors-servo commented Nov 10, 2018

⌛ Trying commit 3f394bf with merge d560597...
bors-servo added a commit that referenced this pull request Nov 10, 2018
@bors-servo
Auto merge of #22149 - CYBAI:rejectionhandled, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d560597 
Implement rejectionhandled event

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22006 .
- [x] There are more tests `PASS`ed for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22149)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 10, 2018

💔 Test failed - linux-rel-css
@CYBAI CYBAI force-pushed the CYBAI:rejectionhandled branch from 3f394bf to c205d84 Nov 10, 2018
@CYBAI
Copy link
Collaborator Author

CYBAI commented Nov 10, 2018

@bors-servo try=wpt
@bors-servo
Copy link
Contributor

bors-servo commented Nov 10, 2018

⌛ Trying commit c205d84 with merge 2b8fbcc...
bors-servo added a commit that referenced this pull request Nov 10, 2018
@bors-servo
Auto merge of #22149 - CYBAI:rejectionhandled, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
2b8fbcc 
Implement rejectionhandled event

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22006 .
- [x] There are more tests `PASS`ed for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22149)
<!-- Reviewable:end -->
@CYBAI
CYBAI reviewed Nov 10, 2018
View changes
...2/unhandled-promise-rejections/promise-rejection-events-onerror.html.ini Outdated Show resolved Hide resolved
@bors-servo
Copy link
Contributor

bors-servo commented Nov 10, 2018

☀️ Test successful - linux-rel-css, linux-rel-wpt
State: approved= try=True
@jdm
Copy link
Member

jdm commented Nov 13, 2018

Yeah, I think we should change the test so it does not rely on the precise wording of the error message that is not specified.
@CYBAI
Introduce rejectionhandled event
23a4d64
@CYBAI CYBAI force-pushed the CYBAI:rejectionhandled branch from c205d84 to 45d5139 Nov 13, 2018
@servo-wpt-sync servo-wpt-sync mentioned this pull request Nov 13, 2018
Merged
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Nov 13, 2018

Opened new PR for upstreamable changes.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#14036.
@jdm
jdm reviewed Nov 13, 2018
View changes
...del-2/unhandled-promise-rejections/promise-rejection-events-onerror.html Outdated Show resolved Hide resolved
CYBAI added 2 commits Nov 13, 2018
@CYBAI
Check including the error message from Error constructor as required
0d6ead9
@CYBAI
Update tests expectation
Loading status checks…
0524bc8
@CYBAI CYBAI force-pushed the CYBAI:rejectionhandled branch from 45d5139 to 0524bc8 Nov 13, 2018
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Nov 13, 2018

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#14036.
@jdm
Copy link
Member

jdm commented Nov 15, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Nov 15, 2018

📌 Commit 0524bc8 has been approved by jdm
@highfive highfive assigned jdm and unassigned asajeffrey Nov 15, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Nov 15, 2018

⌛ Testing commit 0524bc8 with merge 24cb749...
bors-servo added a commit that referenced this pull request Nov 15, 2018
@bors-servo
Auto merge of #22149 - CYBAI:rejectionhandled, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
24cb749 
Implement rejectionhandled event

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22006 .
- [x] There are more tests `PASS`ed for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22149)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 15, 2018

☀️ Test successful - android, android-mac, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, status-taskcluster, windows-msvc-dev
Approved by: jdm
Pushing 24cb749 to master...
@bors-servo bors-servo merged commit 0524bc8 into servo:master Nov 15, 2018
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Nov 15, 2018
Merged
@CYBAI CYBAI deleted the CYBAI:rejectionhandled branch Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdm jdm

Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Implement rejectionhandled event
6 participants
@CYBAI @highfive @bors-servo @jdm @servo-wpt-sync @asajeffrey
You can’t perform that action at this time.