Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix the magicleap CI build #22150
Merged
Fix the magicleap CI build #22150
Conversation
highfive
commented
Nov 8, 2018
|
Heads up! This PR modifies the following files:
|
|
@bors-servo try=magicleap |
bors-servo
added a commit
that referenced
this pull request
Nov 8, 2018
[WIP] Fix the magicleap CI build <!-- Please describe your changes on the following line: --> This is a WIP PR to diagnose and fix the magicleap build in CI. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes do not require tests because it's fixing the build <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22150) <!-- Reviewable:end -->
|
|
|
@bors-servo try=magicleap |
bors-servo
added a commit
that referenced
this pull request
Nov 8, 2018
[WIP] Fix the magicleap CI build <!-- Please describe your changes on the following line: --> This is a WIP PR to diagnose and fix the magicleap build in CI. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes do not require tests because it's fixing the build <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22150) <!-- Reviewable:end -->
|
Landed servo/saltfs#915 which installs makedepend. @bors-servo try=magicleap |
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Nov 9, 2018
[WIP] Fix the magicleap CI build <!-- Please describe your changes on the following line: --> This is a WIP PR to diagnose and fix the magicleap build in CI. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [x] These changes do not require tests because it's fixing the build <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22150) <!-- Reviewable:end -->
|
|
|
|
|
Hmm, that would probably be caused by https://github.com/servo/saltfs/blob/bcc78d578b094e06af93911388e4e0d314adb303/servo-build-dependencies/mac-magicleap.sls#L18 the second time this is run, this will remove execute permission from the binaries, sigh. Could just remove |
|
Yay, servo/saltfs#916 and a bit of manual intervention results in: @bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Nov 9, 2018
[WIP] Fix the magicleap CI build <!-- Please describe your changes on the following line: --> This is a WIP PR to diagnose and fix the magicleap build in CI. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [x] These changes do not require tests because it's fixing the build <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22150) <!-- Reviewable:end -->
|
|
|
Hmm, still building blurdroid. |
|
Yeah, I discovered that when doing a build locally as well with this patch applied. |
asajeffrey
force-pushed the
asajeffrey:magicleap-fix-ci-build
branch
from
32c47b9
to
4752b64
|
|
6 similar comments
|
|
|
|
|
|
|
|
|
|
|
|
asajeffrey
force-pushed the
asajeffrey:magicleap-fix-ci-build
branch
from
4d0e8a5
to
08270f0
|
Rebased and updated device crate. @bors-servo r=jdm |
|
|
bors-servo
added a commit
that referenced
this pull request
Nov 9, 2018
Fix the magicleap CI build <!-- Please describe your changes on the following line: --> This is a WIP PR to diagnose and fix the magicleap build in CI. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [x] These changes do not require tests because it's fixing the build <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22150) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this pull request
Nov 9, 2018
Fix the magicleap CI build <!-- Please describe your changes on the following line: --> This is a WIP PR to diagnose and fix the magicleap build in CI. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [x] These changes do not require tests because it's fixing the build <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22150) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
|
|
|
|
|
@bors-servo retry |
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
asajeffrey commentedNov 8, 2018
•
edited
This is a WIP PR to diagnose and fix the magicleap build in CI.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is