Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd a transparent hit-testing rectangle for scrollable block content. #22156
+43
−1
Conversation
highfive
commented
Nov 9, 2018
|
Heads up! This PR modifies the following files:
|
highfive
commented
Nov 9, 2018
|
|
|
r? @pcwalton |
|
This allows http://asvd.github.io/dragscroll/ to be scrolled with the trackpad regardless of where the mouse is placed. |
|
r+ |
|
@bors-servo r=pcwalton |
|
|
bors-servo
added a commit
that referenced
this pull request
Nov 10, 2018
Add a transparent hit-testing rectangle for scrollable block content. This implements the strategy described at servo/webrender#3261 (comment) and which Gecko uses as well. Adding a transparent rectangle below the content and above the background ensures that hit testing correctly associates the background area with the right scrolling node. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #22073 - [x] These changes do not require tests because the affected codepath requires user input, and we don't support webdriver tests yet. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22156) <!-- Reviewable:end -->
|
|
This was referenced Feb 5, 2019
bors-servo
added a commit
that referenced
this pull request
Feb 6, 2019
Ensure transparent hit test region is sized and positioned correctly. This addresses some edge cases that were missed by #22156. Specifically, in some cases the transparent region was being placed in the display list in front of the scrollable content, rather than behind it, and the size of the region did not account for parent stacking context. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #22073 and fix #22216. - [x] There are tests for these changes <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22839) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this pull request
Feb 6, 2019
Ensure transparent hit test region is sized and positioned correctly. This addresses some edge cases that were missed by #22156. Specifically, in some cases the transparent region was being placed in the display list in front of the scrollable content, rather than behind it, and the size of the region did not account for parent stacking context. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #22073 and fix #22216. - [x] There are tests for these changes <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22839) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jdm commentedNov 9, 2018
•
edited by SimonSapin
This implements the strategy described at servo/webrender#3261 (comment) and which Gecko uses as well. Adding a transparent rectangle below the content and above the background ensures that hit testing correctly associates the background area with the right scrolling node.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is