Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upEnable old glyph assertion #22165
Merged
Enable old glyph assertion #22165
Conversation
The assertion had a note that it should be enabled when something like debug_assert is available.
highfive
commented
Nov 10, 2018
|
|
|
@bors-servo try=wpt |
bors-servo
added a commit
that referenced
this pull request
Nov 10, 2018
Enable old glyph assertion The assertion had a note that it should be enabled when something like debug_assert is available. This must have been disabled since before Rust 1.0 as it uses invalid syntax. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22165) <!-- Reviewable:end -->
|
|
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Nov 15, 2018
Enable old glyph assertion The assertion had a note that it should be enabled when something like debug_assert is available. This must have been disabled since before Rust 1.0 as it uses invalid syntax. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22165) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Nov 16, 2018
Enable old glyph assertion The assertion had a note that it should be enabled when something like debug_assert is available. This must have been disabled since before Rust 1.0 as it uses invalid syntax. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22165) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Nov 16, 2018
Enable old glyph assertion The assertion had a note that it should be enabled when something like debug_assert is available. This must have been disabled since before Rust 1.0 as it uses invalid syntax. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22165) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pyfisch commentedNov 10, 2018
•
edited by SimonSapin
The assertion had a note that it should be enabled
when something like debug_assert is available.
This must have been disabled since before Rust 1.0 as it uses invalid syntax.
This change is