Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OffscreenCanvas API #22168

Closed

Fixed few errors following Josh's review

Followed Josh's review 1 and 4
  • Loading branch information
PrayaniSingh0106 committed Nov 13, 2018
commit a51bb61e4b74cf7460b64b0b306830d74ea111da
@@ -21,10 +21,12 @@
use dom::webgl2renderingcontext::WebGL2RenderingContext;
use js::rust::HandleValue;
use js::jsapi::JSContext;
use dom::bindings::trace::RootedTraceableBox;
use dom::node::{Node, window_from_node};
use dom::bindings::codegen::UnionTypes::OffscreenCanvasRenderingContext2DOrWebGLRenderingContextOrWebGL2RenderingContext;
use dom::eventtarget::EventTarget;


#[derive(JSTraceable, MallocSizeOf)]
pub enum OffscreenRenderingContext {
Context2D(Dom<OffscreenCanvasRenderingContext2D>),
WebGL(Dom<WebGLRenderingContext>),
@@ -33,7 +35,7 @@

#[dom_struct]
pub struct OffscreenCanvas{
reflector_: Reflector,
eventtarget: EventTarget,
height: u64,
width: u64,
context: DomRefCell<Option<OffscreenRenderingContext>>,
@@ -43,23 +45,28 @@
impl OffscreenCanvas{
pub fn new_inherited(height: u64, width: u64, placeholder: Option<&HTMLCanvasElement>) -> OffscreenCanvas {
OffscreenCanvas {
reflector_: Reflector::new(),
eventtarget: EventTarget::new_inherited(),
height: height,
width: width,
context: DomRefCell::new(None),
placeholder: placeholder.map(Dom::from_ref),
}
}

pub fn new(global: &GlobalScope, height: u64, width: u64, placeholder: Option<&HTMLCanvasElement>) -> DomRoot<OffscreenCanvas> {
reflect_dom_object(Box::new(OffscreenCanvas::new_inherited(height,width,placeholder)), global, OffscreenCanvasWrap)
pub fn new(
global: &GlobalScope,
height: u64,
width: u64,
placeholder: Option<&HTMLCanvasElement>
) -> DomRoot<OffscreenCanvas> {
reflect_dom_object(Box::new
(OffscreenCanvas::new_inherited(height,width,placeholder)), global, OffscreenCanvasWrap)
}

pub fn Constructor (global: &GlobalScope, height: u64, width: u64) -> Fallible<DomRoot<OffscreenCanvas>> {
//step 1
let offscreencanvas = OffscreenCanvas::new(global,height,width,None);
//step 2

if offscreencanvas.context.borrow().is_some() {
return Err(Error::InvalidState);
}
@@ -112,14 +119,14 @@
}


/*match &*contextID {
/* match &*contextID {
"2d" => self.get_or_init_2d_context(),
"webgl" | "experimental-webgl" => self
.map(CanvasRenderingContext::WebGLRenderingContext),
"webgl2" | "experimental-webgl2" => self
.map(CanvasRenderingContext::WebGL2RenderingContext)
_ => None,
}*/
} */

}

ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.