Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate webidl of ServiceWorkerRegistration #22171
Merged
Conversation
highfive
commented
Nov 11, 2018
|
Heads up! This PR modifies the following files:
|
highfive
commented
Nov 11, 2018
|
|
|
@bors-servo try=wpt |
bors-servo
added a commit
that referenced
this pull request
Nov 11, 2018
Update webidl of ServiceWorkerRegistration I'll start to work on #19302 and I'd like to update these sw related webidl one by one. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes is part of #19302 - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22171) <!-- Reviewable:end -->
|
|
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Nov 13, 2018
Update webidl of ServiceWorkerRegistration I'll start to work on #19302 and I'd like to update these sw related webidl one by one. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes is part of #19302 - [x] These changes do not require tests because it just updates the webidl for `ServiceWorkerRegistration`; related tests should be updated when we start to implement its functions. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22171) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
|
|
bors-servo
added a commit
that referenced
this pull request
Nov 13, 2018
Update webidl of ServiceWorkerRegistration I'll start to work on #19302 and I'd like to update these sw related webidl one by one. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes is part of #19302 - [x] These changes do not require tests because it just updates the webidl for `ServiceWorkerRegistration`; related tests should be updated when we start to implement its functions. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22171) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Nov 15, 2018
Update webidl of ServiceWorkerRegistration I'll start to work on #19302 and I'd like to update these sw related webidl one by one. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes is part of #19302 - [x] These changes do not require tests because it just updates the webidl for `ServiceWorkerRegistration`; related tests should be updated when we start to implement its functions. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22171) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
|
|
bors-servo
added a commit
that referenced
this pull request
Nov 16, 2018
Update webidl of ServiceWorkerRegistration I'll start to work on #19302 and I'd like to update these sw related webidl one by one. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes is part of #19302 - [x] These changes do not require tests because it just updates the webidl for `ServiceWorkerRegistration`; related tests should be updated when we start to implement its functions. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22171) <!-- Reviewable:end -->
|
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Nov 16, 2018
Update webidl of ServiceWorkerRegistration I'll start to work on #19302 and I'd like to update these sw related webidl one by one. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes is part of #19302 - [x] These changes do not require tests because it just updates the webidl for `ServiceWorkerRegistration`; related tests should be updated when we start to implement its functions. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22171) <!-- Reviewable:end -->
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Nov 16, 2018
Update webidl of ServiceWorkerRegistration I'll start to work on #19302 and I'd like to update these sw related webidl one by one. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes is part of #19302 - [x] These changes do not require tests because it just updates the webidl for `ServiceWorkerRegistration`; related tests should be updated when we start to implement its functions. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22171) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
CYBAI commentedNov 11, 2018
•
edited
I'll start to work on #19302 and I'd like to update these sw related webidl one by one.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsServiceWorkerRegistration; related tests should be updated when we start to implement its functions.This change is