Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd string validation to ShaderSource; #21754 #22189
Closed
Conversation
highfive
commented
Nov 13, 2018
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon. |
highfive
commented
Nov 13, 2018
|
Heads up! This PR modifies the following files:
|
highfive
commented
Nov 13, 2018
|
|
|
@bors-servo try=wpt |
bors-servo
added a commit
that referenced
this pull request
Nov 13, 2018
Add string validation to ShaderSource; #21754 Add string validation to ShaderSource --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #21754 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because there is at least one existing test. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22189) <!-- Reviewable:end -->
|
|
|
r? @nox |
|
@sumit0190 Do you need help to amend your commits to address @Manishearth remarks and mine? |
|
Please address @Manishearth's nits and my two remarks. |
|
Closing due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
sumit0190 commentedNov 13, 2018
•
edited by SimonSapin
Add string validation to ShaderSource
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is