Ensure Node.normalize() normalizes all descendants #2219

hmac · 2014-04-24T14:53:34Z

Fixes #2170 by recursively calling normalize() on all children that aren't text nodes.

At the time of writing the master branched passed 2/3 of the Node-normalize wpt tests. This branch passes 3/3.

I wrestled for a while with the compiler over pointers and lost, resorting to clone(). I imagine there's a way of doing it that avoids that but I couldn't work it out.

highfive · 2014-04-24T14:53:37Z

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @metajack (or someone else) soon.

hoppipolla-critic-bot · 2014-04-24T14:53:39Z

Critic review: https://critic.hoppipolla.co.uk/r/1371

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

jdm · 2014-04-24T14:56:26Z

If you squash these, I'll r+. What you did is what's necessary right; it will be nicer when #2101 is merged and no argument is necessary.


        Implement CharacterData.{deleteData, insertData, replaceData}


        Ensure JS-owned memory is not leaked if a script task fails. Fixes #2201

.


        Add testcase #2025 for document.getElementById().


        Make Attr::SetValue uses the internal setter.


        Make Attr::SetValue to reflect attribute change.


        Make Attr handles all setting value.


        Remove all traces of WindowProxy. Implement basic browser context con…

…cept and outerizing of inner windows.


        Implement ParentNode.children for Document and Element

Also implement it for DocumentFragment


        Implement Element.localName.(fixes #2188)


        Update expectations.


        Remove unused invalidate_rect code


        Make sure RefCell borrows are temporary.

This fixes two `RefCell<T> is already borrowed` failures when reloading an existing pipeline, both caused by functions trying to modify `Pipeline::url` or `ScriptTask::url` while a reference to a previous borrow is still in scope.


        Make the I Tried star appear when a top-level page load fails for net…

…work-related reasons. Under the hood, this requires treating the I Tried pipeline as a new load instead of a replacement, since the failure-handling code interacts poorly with the rest of the replacement code when we get a series of staggered failures over time from the various pipeline components.


        Add NodeHelpers::get_bounding_content_box().


        Add NodeHelpers::get_content_boxes().


        Add Page::hit_test().


        Add Page::get_nodes_under_mouse().


        Ensure Node.Normalize() acts on all descendents by recursively callin…

…g it on all non-text child nodes.

hmac · 2014-04-24T15:18:58Z

damn, that's not what I wanted to do. I'll scrap this and try again.

lpy and others added 18 commits Apr 20, 2014

Implement CharacterData.{deleteData, insertData, replaceData}

ba75603

Ensure JS-owned memory is not leaked if a script task fails. Fixes #2201

ed2c296

.

Add testcase #2025 for document.getElementById().

8f07065

Make Attr::SetValue uses the internal setter.

c376441

Make Attr::SetValue to reflect attribute change.

a81826e

Make Attr handles all setting value.

857eaf5

Remove all traces of WindowProxy. Implement basic browser context con…

bc17d2f

…cept and outerizing of inner windows.

Implement ParentNode.children for Document and Element

fe64fcc

Also implement it for DocumentFragment

Implement Element.localName.(fixes #2188)

4f07d18

Update expectations.

f1c46b0

Remove unused invalidate_rect code

5300096

Make sure RefCell borrows are temporary.

d87a45f

This fixes two `RefCell<T> is already borrowed` failures when reloading an existing pipeline, both caused by functions trying to modify `Pipeline::url` or `ScriptTask::url` while a reference to a previous borrow is still in scope.

Add NodeHelpers::get_bounding_content_box().

7506ba3

Add NodeHelpers::get_content_boxes().

335cfa5

Add Page::hit_test().

3804831

Add Page::get_nodes_under_mouse().

4384a14

Ensure Node.Normalize() acts on all descendents by recursively callin…

1042b4b

…g it on all non-text child nodes.

hmac closed this Apr 24, 2014

hmac deleted the hmac:normalize branch Apr 24, 2014

servo / servo

Ensure Node.normalize() normalizes all descendants #2219

Ensure Node.normalize() normalizes all descendants #2219

hmac commented Apr 24, 2014

highfive commented Apr 24, 2014

hoppipolla-critic-bot commented Apr 24, 2014

jdm commented Apr 24, 2014

hmac commented Apr 24, 2014

servo / servo

Join GitHub today

Ensure Node.normalize() normalizes all descendants #2219

Ensure Node.normalize() normalizes all descendants #2219

Conversation

hmac commented Apr 24, 2014

highfive commented Apr 24, 2014

hoppipolla-critic-bot commented Apr 24, 2014

jdm commented Apr 24, 2014

hmac commented Apr 24, 2014