Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add only one architecture per apk #22196

Merged
merged 1 commit into from Nov 17, 2018
Merged

Add only one architecture per apk #22196

merged 1 commit into from Nov 17, 2018

Conversation

@paulrouget
Copy link
Contributor

paulrouget commented Nov 14, 2018 •
edited by SimonSapin

Fix #22192

This change is Reviewable
@paulrouget
Add only one architecture per apk
Loading status checks…
971bda7
@paulrouget
Copy link
Contributor Author

paulrouget commented Nov 14, 2018

We do it for the AAR but not for the APK.
@paulrouget paulrouget mentioned this pull request Nov 14, 2018
Closed
@Manishearth
Copy link
Member

Manishearth commented Nov 14, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Nov 14, 2018

📌 Commit 971bda7 has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Nov 14, 2018

⌛ Testing commit 971bda7 with merge dfd0690...
bors-servo added a commit that referenced this pull request Nov 14, 2018
@bors-servo
Auto merge of #22196 - paulrouget:ndkfilter, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
dfd0690 
Add only one architecture per apk

Fix #22192

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22196)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 14, 2018

💔 Test failed - android-mac
@Manishearth
Copy link
Member

Manishearth commented Nov 14, 2018

@bors-servo treeclosed=1000
@Manishearth
Copy link
Member

Manishearth commented Nov 14, 2018

(android is busted)
@jdm
Copy link
Member

jdm commented Nov 15, 2018

@bors-servo retry
bors-servo added a commit that referenced this pull request Nov 16, 2018
@bors-servo
Auto merge of #22196 - paulrouget:ndkfilter, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
1593c3b 
Add only one architecture per apk

Fix #22192

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22196)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 16, 2018

⌛ Testing commit 971bda7 with merge 1593c3b...
@bors-servo
Copy link
Contributor

bors-servo commented Nov 16, 2018

💔 Test failed - linux-dev
@jdm
Copy link
Member

jdm commented Nov 16, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Nov 16, 2018

💣 Failed to start rebuilding: Unknown error
bors-servo added a commit that referenced this pull request Nov 16, 2018
@bors-servo
Auto merge of #22196 - paulrouget:ndkfilter, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d7035a9 
Add only one architecture per apk

Fix #22192

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22196)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 16, 2018

⌛ Testing commit 971bda7 with merge d7035a9...
@bors-servo
Copy link
Contributor

bors-servo commented Nov 16, 2018

💔 Test failed - linux-dev
@jdm
Copy link
Member

jdm commented Nov 16, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Nov 16, 2018

⌛ Testing commit 971bda7 with merge 0ab2c3f...
bors-servo added a commit that referenced this pull request Nov 16, 2018
@bors-servo
Auto merge of #22196 - paulrouget:ndkfilter, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0ab2c3f 
Add only one architecture per apk

Fix #22192

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22196)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 17, 2018

☀️ Test successful - android, android-mac, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster, windows-msvc-dev
Approved by: Manishearth
Pushing 0ab2c3f to master...
@bors-servo bors-servo merged commit 971bda7 into servo:master Nov 17, 2018
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@paulrouget @Manishearth @bors-servo @jdm @highfive
You can’t perform that action at this time.