New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up some code on the WebGL texture upload paths #22202

Merged
merged 11 commits into from Nov 17, 2018

Conversation

Projects
None yet
4 participants
@nox
Member

nox commented Nov 15, 2018

This doesn't actually change anything… yet.


This change is Reviewable

@jdm

This comment has been minimized.

Member

jdm commented Nov 15, 2018

test-tidy has a lot to say. There's also a gleam patch in Cargo.toml that needs to be removed.

@jdm

This comment has been minimized.

Member

jdm commented Nov 16, 2018

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 16, 2018

📌 Commit af2b4db has been approved by jdm

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 17, 2018

⌛️ Testing commit af2b4db with merge 6b1fccf...

bors-servo added a commit that referenced this pull request Nov 17, 2018

Auto merge of #22202 - servo:webgl, r=jdm
Clean up some code on the WebGL texture upload paths

This doesn't actually change anything… yet.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22202)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 17, 2018

💔 Test failed - linux-rel-wpt

@jdm

This comment has been minimized.

Member

jdm commented Nov 17, 2018

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 17, 2018

⌛️ Testing commit af2b4db with merge 94991db...

bors-servo added a commit that referenced this pull request Nov 17, 2018

Auto merge of #22202 - servo:webgl, r=jdm
Clean up some code on the WebGL texture upload paths

This doesn't actually change anything… yet.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22202)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

@bors-servo bors-servo merged commit af2b4db into master Nov 17, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment