New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a laser pointer rather than the trackpad to control web content #22206

Merged
merged 1 commit into from Nov 17, 2018

Conversation

Projects
None yet
5 participants
@asajeffrey
Member

asajeffrey commented Nov 15, 2018

Replace the trackpad with a laser pointer in the magicleap app.


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #22184.
  • These changes do not require tests because no testing for ML

This change is Reviewable

@asajeffrey

This comment has been minimized.

Member

asajeffrey commented Nov 15, 2018

@bors-servo try=magicleap

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 15, 2018

⌛️ Trying commit deb599f with merge 9b17ae9...

bors-servo added a commit that referenced this pull request Nov 15, 2018

Auto merge of #22206 - asajeffrey:magicleap-sharks-with-frikkin-laser…
…s, r=<try>

Use a laser pointer rather than the trackpad to control web content

<!-- Please describe your changes on the following line: -->

Replace the trackpad with a laser pointer in the magicleap app.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #22184.

<!-- Either: -->
- [X] These changes do not require tests because no testing for ML

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22206)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 15, 2018

☀️ Test successful - magicleap
State: approved= try=True

@jdm

This comment has been minimized.

Member

jdm commented Nov 17, 2018

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 17, 2018

📌 Commit deb599f has been approved by jdm

@highfive highfive assigned jdm and unassigned SimonSapin Nov 17, 2018

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 17, 2018

⌛️ Testing commit deb599f with merge 1476885...

bors-servo added a commit that referenced this pull request Nov 17, 2018

Auto merge of #22206 - asajeffrey:magicleap-sharks-with-frikkin-laser…
…s, r=jdm

Use a laser pointer rather than the trackpad to control web content

<!-- Please describe your changes on the following line: -->

Replace the trackpad with a laser pointer in the magicleap app.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #22184.

<!-- Either: -->
- [X] These changes do not require tests because no testing for ML

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22206)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

@bors-servo bors-servo merged commit deb599f into servo:master Nov 17, 2018

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment